fix/docs(readme): javascript truthy shenanigans #1976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specific section is confusing.
indexOf
returns-1
when the string is not found, i.e. atruthy
value.Hence, the docs suggest that for some reason, the
napMap
application would apply if and only if theindex
of the string30001
is not 0.I think it would be a clearer read to use
includes
as it more accurately aligns with an expected usecase