fix: update command execution in devices #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptadev21
force-pushed
the
fix/piping-tunnel
branch
from
11f2f19 to
567f47d
Compare
guptadev21
force-pushed
the
fix/piping-tunnel
branch
from
c743b8f to
f8d140e
Compare
ankitrgadiya
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
run_asyncflag in the Command class to enhance command execution behavior.The existing
bgflag is now strictly used to run commands in the background. When used, it will return only SUCCESS, regardless of whether the command fails on the device. It will not return a job ID (jid).The new
run_asyncflag allows commands to be executed asynchronously. When set, the command will be sent to the device, and a jid will be returned immediately. We won’t wait for the command to complete; instead, the system will poll every 30 seconds to check the command's status.resolves https://github.com/rapyuta-robotics/rapyuta_io/issues/820