feat(dockercache): add registry blob storage option #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptadev21
added
the
type/feature ✨
|
🤖 Pull Request Artifacts (#15486533007) 🎉 |
guptadev21
force-pushed
the
feat/registry-blobstorage
branch
from
615eac1 to
74de440
Compare
guptadev21
force-pushed
the
feat/registry-blobstorage
branch
2 times, most recently
from
dde2dc4 to
481dd5f
Compare
ankitrgadiya
requested changes
Jun 6, 2025
| @@ -98,6 +98,8 @@ definitions: | |||
| type: string | |||
| registryURL: | |||
| type: string | |||
| dataDirectory: | |||
| type: string | |||
There was a problem hiding this comment.
todo: Add the default value in the schema.
Comment on lines
58
to
59
| default=(), | ||
| help="Registry data directory path (default: /opt/rapyuta/volumes/docker-cache/)", |
There was a problem hiding this comment.
todo: Specify the value in the default field and remove from the help. The Click library automatically displays the default value.
There was a problem hiding this comment.
Pull Request Overview
Adds support for specifying a custom data directory for the Docker cache registry.
- Introduce
--data-directoryCLI flag fordockercache - Include
dataDirectoryin the API payload and JSON schema - Update example manifest with the new field
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| riocli/project/features/dockercache.py | Adds --data-directory option and passes it in payload |
| riocli/jsonschema/schemas/project-schema.yaml | Declares dataDirectory property in project schema |
| riocli/apply/manifests/project.yaml | Adds dataDirectory to example project manifest |
Comments suppressed due to low confidence (3)
riocli/jsonschema/schemas/project-schema.yaml:101
- The new
dataDirectoryschema entry lacks a description; addingdescription: 'Path to registry data directory'will improve clarity for consumers.
dataDirectory:
riocli/apply/manifests/project.yaml:29
- [nitpick] This example path (
/opt/rapyuta/volumes/) differs from the help text default (/opt/rapyuta/volumes/docker-cache/); consider aligning them to avoid confusion.
dataDirectory: "/opt/rapyuta/volumes/"
riocli/project/features/dockercache.py:56
- Add or update CLI tests to cover the new
--data-directoryflag and ensure it’s passed correctly in the request payload.
--data-directory
guptadev21
force-pushed
the
feat/registry-blobstorage
branch
from
481dd5f to
9602b50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/rapyuta-robotics/rapyuta_io/issues/742