Skip to content

Use range in cmake_minimum #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Use range in cmake_minimum #125

merged 2 commits into from
Feb 11, 2025

Conversation

zmbc
Copy link
Contributor

@zmbc zmbc commented Jan 29, 2025

Resolves the following deprecation warning I got when building with CMake 3.31.5:

CMake Deprecation Warning at CMakeLists.txt:2 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

@zmbc
Copy link
Contributor Author

zmbc commented Jan 29, 2025

Is 3.24 the right max on the range? I saw it on the next lines of the file so figured it was a safe bet.

@maxbachmann
Copy link
Member

Shouldn't the right max be 3.31 for you to build with it? I don't see any reason why we wouldn't support it.

@zmbc
Copy link
Contributor Author

zmbc commented Jan 30, 2025

It's not the maximum version it will build with, but the "maximum of the minimum" (not confusing at all). Basically I think it's supposed to be the maximum version it's been tested with. Hm, maybe 3.31 would make more sense on that criterion as well...

@maxbachmann maxbachmann merged commit a6bd162 into rapidfuzz:main Feb 11, 2025
46 checks passed
@zmbc zmbc deleted the cmake_minimum branch February 11, 2025 19:35
@zmbc
Copy link
Contributor Author

zmbc commented Feb 11, 2025

Thanks @maxbachmann! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants