-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Implement daily-aarch64-development.yml #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement daily-aarch64-development.yml #1539
Conversation
This comment has been minimized.
This comment has been minimized.
Hi @gsmet could you review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I added several comments, please have a look and let me know if you need any help!
(I will have very limited availability until Tuesday morning, though)
7988164
to
4795d78
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hey @gsmet , I made the changes requested. |
Hi @gsmet could we merge it? |
4795d78
to
7b19afd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and added a few fixes/improvements in both workflows.
Could you have a look at my question?
7b19afd
to
83f5b0e
Compare
This comment has been minimized.
This comment has been minimized.
FYI, I'm currently testing both workflows in my fork. |
This comment has been minimized.
This comment has been minimized.
83f5b0e
to
dba82d1
Compare
dba82d1
to
2e08f4f
Compare
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs |
---|---|---|---|---|---|
✖ | Build - JDK 17 | Build with Maven |
Failures | Logs | Raw logs |
Full information is available in the Build summary check run.
Failures
⚙️ Build - JDK 17 #
- Failing: hibernate-orm-jakarta-data-quickstart
📦 hibernate-orm-jakarta-data-quickstart
✖ org.acme.hibernate.orm.FruitsEndpointTest.testListAllFruits
line 20
- More details - Source on GitHub
java.lang.AssertionError:
1 expectation failed.
Expected status code <200> but was <500>.
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
The failure check is due to the hibernate-orm-jakarta-data-quickstart module...not sure why right now, but it's not related to this. |
Thanks! |
Summary
This PR extends the existing quickstarts CI workflows to include aarch64 runner support
Check list:
Your pull request:
development
branch999-SNAPSHOT
version of Quarkusmvn clean test
)mvn clean package -Pnative
)mvn clean verify -Pnative
)README.md
file (with build and run instructions)pom.xml
andREADME.md