Skip to content

Implement daily-aarch64-development.yml #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

jcarranzan
Copy link
Contributor

Summary

This PR extends the existing quickstarts CI workflows to include aarch64 runner support

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

This comment has been minimized.

@jcarranzan
Copy link
Contributor Author

Hi @gsmet could you review it?
Thanks

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I added several comments, please have a look and let me know if you need any help!

(I will have very limited availability until Tuesday morning, though)

This comment has been minimized.

This comment has been minimized.

@jcarranzan jcarranzan requested a review from gsmet June 5, 2025 10:27
@jcarranzan
Copy link
Contributor Author

Hey @gsmet , I made the changes requested.
Let me know if everything is ok, thanks.

@jcarranzan
Copy link
Contributor Author

Hi @gsmet could we merge it?

@gsmet gsmet force-pushed the implement-aarch64-ci-dev branch from 4795d78 to 7b19afd Compare June 12, 2025 07:39
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased and added a few fixes/improvements in both workflows.

Could you have a look at my question?

@gsmet gsmet force-pushed the implement-aarch64-ci-dev branch from 7b19afd to 83f5b0e Compare June 12, 2025 07:43

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Jun 12, 2025

FYI, I'm currently testing both workflows in my fork.

This comment has been minimized.

@jcarranzan jcarranzan force-pushed the implement-aarch64-ci-dev branch from 83f5b0e to dba82d1 Compare June 12, 2025 08:27
@jcarranzan jcarranzan force-pushed the implement-aarch64-ci-dev branch from dba82d1 to 2e08f4f Compare June 12, 2025 08:28

This comment has been minimized.

Copy link

quarkus-bot bot commented Jun 12, 2025

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit dba82d1.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Build - JDK 17 #

- Failing: hibernate-orm-jakarta-data-quickstart 

📦 hibernate-orm-jakarta-data-quickstart

org.acme.hibernate.orm.FruitsEndpointTest.testListAllFruits line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

@jcarranzan
Copy link
Contributor Author

The failure check is due to the hibernate-orm-jakarta-data-quickstart module...not sure why right now, but it's not related to this.

@gsmet gsmet merged commit a24b5e2 into quarkusio:development Jun 13, 2025
2 of 3 checks passed
@gsmet
Copy link
Member

gsmet commented Jun 13, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants