Skip to content

[HUD] Crude way to show if log classifier error matches aggregate disable issue #6695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jun 2, 2025

I'm open to other solutions, this is pretty crude

Things I'm not sure how to handle:

  • If a test was recently reenabled, we like to link the issue since issue closing + change landing can be out of sync and knowing there was a disable issue can be useful context. But I would also prefer to not reopen aggregate issues and I'm not sure how to discourage that
  • If there are multiple disable issues for a test

Alt solutions:

Copy link

vercel bot commented Jun 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Jun 2, 2025 10:48pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2025
@clee2000 clee2000 marked this pull request as ready for review June 2, 2025 22:48
@clee2000 clee2000 requested a review from a team June 2, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants