[poetry] when running prep_binary_for_pypi inject linux metadata to all wheels #6681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
atalman
commented
May 29, 2025
| @@ -17,7 +18,41 @@ | |||
| from pathlib import Path | |||
|
|
|||
|
|
|||
| def process_wheel(whl_file, output_dir=None): | |||
| cuda_metadata_inject = """Requires-Dist: nvidia-cuda-nvrtc-cu12==12.6.77; platform_system == "Linux" and platform_machine == "x86_64" | |||
There was a problem hiding this comment.
I am not really fan of this section.
One Possibility is to Construct this on the fly from:
https://github.com/pytorch/pytorch/blob/main/.github/scripts/generate_binary_build_matrix.py#L58
Triton can be extracted from here:
https://github.com/pytorch/pytorch/blob/main/.ci/docker/triton_version.txt
Let me know what you think, I can iterate on this PR and add the logic to construct these requirements on the fly.
Keeping it simple for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR injects linux dependencies to non-linux wheels before uploading them to pypi.
Related to Poetry issue:
pytorch/pytorch#152121
Metadata injection required since it was removed by this PR:
pytorch/pytorch#152333