Add upload-artifact-s3 action #6659
Conversation
…9af838c04fd81a07f1d47
Based on seemethere/upload-artifact-s3@e100392 Co-authored-by: Eli Uriegas <[email protected]> Co-authored-by: Nikita Shulga <[email protected]>
|
@zklaus is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @zklaus! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Hi @zklaus can we include small README.md file in the |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
facebook-github-bot
added
the
CLA Signed
|
When this PR gets merged, we should migrate the use of the older action to the newer one. I have created a tracking issue for that at #6755 |
There was a problem hiding this comment.
Thanks for moving this item along. I know @jwagantall will be happy to see this move forward.
This adds an updated version of the upload-artifact-s3 action to this repo.
It is based on the original actions/upload-artifact action as well as the currently used seemethere/upload-artifact-s3 action.
However, since the latter is based on a rather old version of the former and because there have been substantial changes to the underlying aws-sdk since then, a lot of the s3 code was rewritten and integrated with the latest version of the original actions/upload-artifact action.
Testing was performed in a separate repository; the logs for the test jobs are available.
This version also adds a few s3 specific features, such as new metadata outputs and s3 acl handling, which are detailed in the README.
This PR replaces half of pytorch/pytorch#6269, the other half being the corresponding download action.
It also addresses part of pytorch/ci-infra#242.