Skip to content

Arm backend: Make validate_same_dtype print readable types #11468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Jun 9, 2025

Prior to this change, it was hard to read which types the function validate_same_dtype referred to upon error prints. Modify this function such that it now prints the types in readable format, i.e., the name of the data type instead of its enum value.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Prior to this change, it was hard to read which types the function
validate_same_dtype referred to upon error prints. Modify this function
such that it now prints the types in readable format, i.e., the name of
the data type instead of its enum value.

Change-Id: I92e793d58a58eef53e66fbb765398bb753abb784
@martinlsm martinlsm requested a review from digantdesai as a code owner June 9, 2025 07:18
Copy link

pytorch-bot bot commented Jun 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11468

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4bda304 with merge base e02ca41 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2025
@pytorch pytorch deleted a comment from pytorch-bot bot Jun 9, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jun 9, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@martinlsm
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@zingo zingo added release notes: arm Changes to the ARM backend delegate and removed topic: not user facing labels Jun 9, 2025
@zingo zingo merged commit 42c4cdb into pytorch:main Jun 9, 2025
352 of 358 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants