Skip to content

Qualcomm AI Engine Direct - multi-method support in to_edge_transform_and_lower_to_qnn #11436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

DannyYuyang-quic
Copy link
Collaborator

Summary

  • add support for multi-method in to_edge_transform_and_lower_to_qnn
  • deprecate capture_program in llama.py

Test plan

python -m backends.qualcomm.tests.test_qnn_delegate TestQNNQuantizedUtils.test_qnn_backend_multi_graphs -s ${device_id} -H ${host_id} -m ${soc} -b build-android

@DannyYuyang-quic DannyYuyang-quic requested a review from cccclai as a code owner June 6, 2025 03:50
Copy link

pytorch-bot bot commented Jun 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11436

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 5004945 with merge base 78446d0 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
@DannyYuyang-quic
Copy link
Collaborator Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Jun 6, 2025
@DannyYuyang-quic
Copy link
Collaborator Author

DannyYuyang-quic commented Jun 6, 2025

Hi @cccclai,
This PR aligns our to_edge_transform_and_lower_to_qnn API with to_edge_transform_and_lower, allowing us to deprecate capture_program with weight-sharing in llama.py.

Please have a look.
Thanks!

@DannyYuyang-quic DannyYuyang-quic force-pushed the dev1/danny/support_multi_method branch from 2ff7ca3 to 4643bba Compare June 6, 2025 07:27
…_and_lower_to_qnn

Summary:
- add support for multi-method in to_edge_transform_and_lower_to_qnn
- deprecate capture_program in llama.py
@DannyYuyang-quic DannyYuyang-quic force-pushed the dev1/danny/support_multi_method branch from 4df1ffc to 5004945 Compare June 10, 2025 13:45
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the UX!

@cccclai cccclai merged commit 07be1ff into pytorch:main Jun 11, 2025
102 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants