Skip to content

Qualcomm AI Engine Direct - multi-method support in to_edge_transform_and_lower_to_qnn #11436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Qualcomm AI Engine Direct - multi-method support in to_edge_transform_and_lower_to_qnn #11436

wants to merge 2 commits into from
+156 −110

Conversation

DannyYuyang-quic
Copy link
Collaborator

Summary

  • add support for multi-method in to_edge_transform_and_lower_to_qnn
  • deprecate capture_program in llama.py

Test plan

python -m backends.qualcomm.tests.test_qnn_delegate TestQNNQuantizedUtils.test_qnn_backend_multi_graphs -s ${device_id} -H ${host_id} -m ${soc} -b build-android

@DannyYuyang-quic DannyYuyang-quic requested a review from cccclai as a code owner June 6, 2025 03:50
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11436

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4df1ffc with merge base 50f7376 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
@DannyYuyang-quic
Copy link
Collaborator Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Jun 6, 2025
@DannyYuyang-quic
Copy link
Collaborator Author

DannyYuyang-quic commented Jun 6, 2025 •
edited
Loading

Hi @cccclai,
This PR aligns our to_edge_transform_and_lower_to_qnn API with to_edge_transform_and_lower, allowing us to deprecate capture_program with weight-sharing in llama.py.

Please have a look.
Thanks!

@DannyYuyang-quic
Qualcomm AI Engine Direct - multi-method support in to_edge_transform…
4643bba 
…_and_lower_to_qnn

Summary:
- add support for multi-method in to_edge_transform_and_lower_to_qnn
- deprecate capture_program in llama.py
@DannyYuyang-quic DannyYuyang-quic force-pushed the dev1/danny/support_multi_method branch from 2ff7ca3 to 4643bba Compare June 6, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DannyYuyang-quic @facebook-github-bot