NXP backend: Enable initial unit tests workflow #11396
Conversation
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11396
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 92eea29 with merge base c120b35 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
robert-kalmar
added
module: nxp
| SCRIPT_DIR=$(dirname $(readlink -fm $0)) | ||
| EXECUTORCH_DIR=$(dirname $(dirname $SCRIPT_DIR)) | ||
|
|
||
| cd $EXECUTORCH_DIR |
There was a problem hiding this comment.
Don't we need to install the NXP sdk here? See my PR with retries, I am on phone so can't look it up.
There was a problem hiding this comment.
Done. The test requirements are installed in the trunk.yaml:
# Install test requirements
pip install -r backends/nxp/requirements-tests.txt
|
Looks good, left a comment, and add a trunk label, hopefully it will be all green now. |
.github/workflows/trunk.yml
Outdated
| docker-image: executorch-ubuntu-22.04-clang12 | ||
| submodules: 'true' | ||
| ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} | ||
| timeout: 90 |
There was a problem hiding this comment.
@kirklandsign mentioned it's better to have a separate docker image for a specific backend to avoid unstable CI jobs.
There was a problem hiding this comment.
Sounds reasonable.
For curiosity, the github job runs from a clean docker container, right? It does not reuse already instantiated containers. (I don't see this explicitly from the log, but as the docker image was pulled I guess clean docker container is used)
Where I am heading if we can run the trunk workflow, after my fixes, to chase one error at a time, or we must isolate the build into its own docker container to not break containers for other jobs.
@cccclai , @kirklandsign, can you elaborate more about "unstable CI jobs". The background it to not mix the backends SDK, what can be potentially installed during the docker image creation (https://github.com/pytorch/executorch/blob/main/.ci/docker/ubuntu/Dockerfile#L85)? If I understand the script correctly currently only Android really uses this option, right?
There was a problem hiding this comment.
Addressed is second PR: #11473
.github/workflows/trunk.yml
Outdated
| with: | ||
| runner: linux.2xlarge | ||
| docker-image: executorch-ubuntu-22.04-clang12 | ||
| submodules: 'true' |
There was a problem hiding this comment.
Must be set to "recursive" since 7e034ca.
Fix duplicate bpe tokenizer base symbol (pytorch#63)
robert-kalmar
force-pushed
the
upstream/main-nxp/neutron-unittest-ci
branch
from
1375a85 to
92eea29
Compare
|
@digantdesai , we are green. The failing trunk/test-arm-cortex-m-size-test seems unrelated. It failed on slight size increase for the The @cccclai request is addressed in separate PR #11473 to have a baseline here. Started the tests, if pass, we can merge the PR 11473 instead of this as it contains the |
|
Cc @GregoryComer for Arm size test. |
|
Thanks you guys. Since this is on CI trunk for now, make sure to manually apply trunk label to NXP PRs. Also going forward let's ensure new PRe include tests for the CI so we don't regress silently. |
Summary
Initial workflow definition for running unit tests for Neutron (NXP) backend.
Follow up for the #11109, our IT updated the eIQ PyPI, so the neutron-converter python package shall be reachable using the executorch's self-hosted agents too.
@digantdesai , @mergennachin as the problem was only reproduced with the self-hosted agents used by the ExecuTorch/PyTorch, I need your help to verify the IT change. Can you please let run the "trunk" workflow?
cc @digantdesai @JakeStevens