Ability to set external instance + devices #11393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamGondelman
requested review from
JacobSzwejbka,
lucylq,
swolchok and
SS-JIA
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11393
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 9df0d18 with merge base 120eb85 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71372344 |
SamGondelman
added
the
release notes: api
SamGondelman
force-pushed
the
export-D71372344
branch
from
c37de58 to
fe794de
Compare
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 5, 2025
Summary: Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Differential Revision: D71372344
|
This pull request was exported from Phabricator. Differential Revision: D71372344 |
SamGondelman
force-pushed
the
export-D71372344
branch
from
fe794de to
75a9383
Compare
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 6, 2025
Summary: Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Differential Revision: D71372344
|
This pull request was exported from Phabricator. Differential Revision: D71372344 |
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 6, 2025
Summary: Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Differential Revision: D71372344
SamGondelman
force-pushed
the
export-D71372344
branch
from
75a9383 to
0c29d88
Compare
SS-JIA
approved these changes
Jun 6, 2025
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 6, 2025
Summary: Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Reviewed By: SS-JIA Differential Revision: D71372344
SamGondelman
force-pushed
the
export-D71372344
branch
from
0c29d88 to
00a15f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71372344 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D71372344 |
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: pytorch#11393 Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Reviewed By: SS-JIA Differential Revision: D71372344
SamGondelman
force-pushed
the
export-D71372344
branch
from
00a15f5 to
a5277c3
Compare
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 6, 2025
Summary: Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Reviewed By: SS-JIA Differential Revision: D71372344
SamGondelman
force-pushed
the
export-D71372344
branch
from
a5277c3 to
fd7a72d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71372344 |
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: pytorch#11393 Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Reviewed By: SS-JIA Differential Revision: D71372344
SamGondelman
force-pushed
the
export-D71372344
branch
from
fd7a72d to
5c7c3f3
Compare
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 6, 2025
Summary: Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Reviewed By: SS-JIA Differential Revision: D71372344
SamGondelman
force-pushed
the
export-D71372344
branch
from
5c7c3f3 to
fb01090
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71372344 |
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: pytorch#11393 Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Reviewed By: SS-JIA Differential Revision: D71372344
SamGondelman
force-pushed
the
export-D71372344
branch
from
fb01090 to
4add2bb
Compare
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 6, 2025
Summary: Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Reviewed By: SS-JIA Differential Revision: D71372344
SamGondelman
force-pushed
the
export-D71372344
branch
from
4add2bb to
de9be11
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71372344 |
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: pytorch#11393 Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Reviewed By: SS-JIA Differential Revision: D71372344
SamGondelman
force-pushed
the
export-D71372344
branch
from
de9be11 to
1dcc65c
Compare
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 8, 2025
Summary: Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Reviewed By: SS-JIA Differential Revision: D71372344
SamGondelman
force-pushed
the
export-D71372344
branch
from
1dcc65c to
9565801
Compare
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 8, 2025
Summary: Pull Request resolved: pytorch#11393 Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Reviewed By: SS-JIA Differential Revision: D71372344
|
This pull request was exported from Phabricator. Differential Revision: D71372344 |
SamGondelman
force-pushed
the
export-D71372344
branch
from
9565801 to
4dad6d1
Compare
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Jun 9, 2025
Summary: Adds a new extension to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Reviewed By: SS-JIA Differential Revision: D71372344
SamGondelman
force-pushed
the
export-D71372344
branch
from
4dad6d1 to
a085f62
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71372344 |
Summary: Adds a new function to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice. Reviewed By: SS-JIA Differential Revision: D71372344
SamGondelman
force-pushed
the
export-D71372344
branch
from
a085f62 to
9df0d18
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71372344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds a new function to ETVK, set_and_get_external_adapter, which allows clients to share their Vulkan instance/devices with ETVK. This is useful when using volk, which does not support multiple devices when using volkLoadDevice.
Differential Revision: D71372344