fix anti-pattern for cudagraph #2619
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoyuanFeng
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
BoyuanFeng
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
ydwu4
approved these changes
May 22, 2025
|
@pytorchbot merge |
|
Mergebot is not configured for this repository. Please use the merge button provided by GitHub. |
|
@BoyuanFeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@BoyuanFeng merged this pull request in 227fb01. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
self.create_grids((nx, ny), p.device)is run sometimes, leading to cudagraph error "accessing tensor output of CUDAGraphs that has been overwritten by a subsequent run". This pr fixes the anti-pattern to always runcreate_grids.