feat: support multiple JITO endpoints with round-robin retry #2664
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Ali Behjati <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
| @@ -50,7 +50,7 @@ export default { | |||
| default: 50000, | |||
| } as Options, | |||
| "jito-endpoint": { | |||
There was a problem hiding this comment.
Let's rename this param to jito-endpoints for clarity
| while (Date.now() - startTime < maxRetryTimeMs) { | ||
| const currentClient = clients[clientIndex]; | ||
| try { | ||
| await currentClient.sendBundle(bundle); | ||
| return firstTransactionSignature; | ||
| } catch (err: any) { | ||
| lastError = err; | ||
| clientIndex = (clientIndex + 1) % clients.length; | ||
| await new Promise((resolve) => setTimeout(resolve, 500)); | ||
| } | ||
| } |
There was a problem hiding this comment.
(aside) @guibescos do you know how many jito endpoints we can round robin against? the ratelimit retry logic is a little funky here if there are only 2 or 3.
There was a problem hiding this comment.
(aside) cc @ali-bahjati
There was a problem hiding this comment.
I have never experimented with multiple jito endpoints so I don't have a good take on this!
Co-Authored-By: Ali Behjati <[email protected]>
|
Closing due to inactivity for more than 7 days. |
|
(aside) okay devin is ignoring me -- will test this out manually and make any updates necessary |
…evin/1746706324-solana-jito-multiple-endpoints
| } else { | ||
| throw err; | ||
| try { | ||
| this.logger.info("Sending Jito transactions..."); |
There was a problem hiding this comment.
did you mean to leave these extra logs here?
There was a problem hiding this comment.
improved the logging
| } catch (err: any) { | ||
| lastError = err; | ||
| clientIndex = (clientIndex + 1) % clients.length; | ||
| await new Promise((resolve) => setTimeout(resolve, 500)); |
There was a problem hiding this comment.
why do we need to wait between different endpoints
There was a problem hiding this comment.
Yeah true we don't, will remove
| let lastError: Error | null = null; | ||
| let clientIndex = 0; | ||
|
|
||
| while (Date.now() - startTime < maxRetryTimeMs) { |
There was a problem hiding this comment.
since the pushing frequency is 5 seconds in the production deployment, the scheduler will try to push a fresher bundle 5 seconds after.
60 seconds retry time seems too much, after 5 seconds the current bundle is stale and the current task should terminate
There was a problem hiding this comment.
Good point -- we can just use pushing frequency as the max timeout since we should stop retrying once the next interval comes around.
| { maxRetryTimeMs: this.maxRetryTimeMs }, | ||
| ); | ||
| } catch (err: any) { | ||
| if (err.code === 8 && err.details?.includes("Rate limit exceeded")) { |
There was a problem hiding this comment.
tbh this "timeout" code path was added as an ducttape fix by ayaz so feel free to rework it into some more principled
There was a problem hiding this comment.
yeah, and we'll actually only hit this if we're ratelimited across all endpoints which is pretty unlikely. i'll improve and simplify this.
…evin/1746706324-solana-jito-multiple-endpoints
tejasbadadare
deleted the
devin/1746706324-solana-jito-multiple-endpoints
branch
Multiple JITO Endpoints Support
This PR adds support for multiple JITO endpoints in the Solana price pusher with a round-robin retry mechanism.
Changes:
sendTransactionsJitoto accept a list of SearcherClientsSolanaPricePusherJitoclass to accept multiple endpointsImplementation details:
Link to Devin run: https://app.devin.ai/sessions/4b444e4e547842658001b352436f6970
Requested by: Ali Behjati ([email protected])