refactor(hermes/server): use program accounts instead of mapping acct #2643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tejasbadadare
approved these changes
May 1, 2025
Comment on lines
252
to
254
| while all_ids.is_empty() { | ||
| all_ids = Aggregates::get_price_feed_ids(state).await; | ||
| tracing::info!("Waiting for price feed ids..."); |
There was a problem hiding this comment.
the ordering of these ops means that we'll always have to wait at least 1 second right? should we check all_ids.is_empty() before sleeping?
Comment on lines
282
to
284
| // Product account header: <magic:u32le:0xa1b2c3d4> <version:u32le:0x02> <account_type:u32le:0x02> | ||
| MemcmpEncodedBytes::Bytes(hex::decode("d4c3b2a10200000002000000").unwrap()), | ||
| ))]), |
There was a problem hiding this comment.
does the string literal not match the comment because its BE vs LE? maybe worth mentioning that in the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We used mapping account to get the product metadata but it involves many calls and many node providers have been facing issues with it. This change removes mapping account and uses
getProgramAccountsto fetch all accounts in one go.How has this been tested?