-
Notifications
You must be signed in to change notification settings - Fork 261
feat(apps/hermes): add connection timeout for SSE & WebSocket connections #2612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address my comment before merging and bump the version. Also please update the docs (for SSE at least) to document this behaviour.
…ream duration check
…onnection closure after 24 hours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! one thing i'm wondering about is that there are many clients out there that maintain open connections to hermes. when we deploy this change, they'll all reconnect and start their connection TTLs at the same time. then every 24h there will be a thundering herd of reconnections. we could add a jitter to the 24h to avoid this (give them a variable extra 1-5m after the 24h).
in reality, many of them will drop their connections naturally due to network conditions before 24h elapses, and hermes can probably handle the thundering herd anyway, but just something to be aware of.
Summary
Rationale
How has this been tested?
Testing steps: