Add Flow Refueling Location Model (FRLM) #487
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengzixin0617
commented
Jun 3, 2025
fengzixin0617
commented
- Add FRLM class and example notebook
- With exact and greedy solver options
- Combined capacited FRLM and basic FRLM
- Add FRLM class and example notebook - with exact and greedy solvers
ljwolf
requested changes
Jun 6, 2025
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "G = nx.grid_2d_graph(5, 5)\n", |
There was a problem hiding this comment.
It'd be great if this used the libpysal.graph.Graph class instead of networkx here...
| "plt.figure(figsize=(8, 8))\n", | ||
| "nx.draw_networkx_nodes(G, pos, node_size=300, node_color='skyblue')\n", | ||
| "nx.draw_networkx_edges(G, pos)\n", | ||
| "edge_labels = {(u, v): f\"{d['length']:.1f}\" for u, v, d in G.edges(data=True)}\n", |
There was a problem hiding this comment.
This could use the plotting functionality again in libpysal.graph.Graph, and would fit better within the library.
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", |
There was a problem hiding this comment.
We usually start the notebooks about spopt.locate models with a little bit about the mathematical structure of the MILP being solved. See @gegen07's excellent p-center notebook.
|
|
||
| print("="*60) | ||
|
|
||
| def export_solution(self, filename: str, format: str = 'csv') -> None: |
There was a problem hiding this comment.
This should be implemented as separate write_csv(), write_json() and write_excel() methods.
|
|
||
| return utilization | ||
|
|
||
| def print_problem_details(self): |
There was a problem hiding this comment.
Should this be a summary() method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.