-
Notifications
You must be signed in to change notification settings - Fork 9
feat: stage explorer part 3 #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
==========================================
- Coverage 90.59% 90.52% -0.08%
==========================================
Files 88 89 +1
Lines 9644 9791 +147
==========================================
+ Hits 8737 8863 +126
- Misses 907 928 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
just keeps getting better! the position outline is awesome. I tried to make it "hard" by decreasing the velocity of the demo cam and it works great. But found a small inconsistency: when you double click on a position, it does not poll as it moves, but when you click the stage widget it does. This probably indicates something deeper about how we deal with threading in the two scenarios (and may harken back to #410 ... and indicate that we need more conveniences around slow stage moves), but see what happens here: Untitled.movalso, definitely related to #410: if you have snap-on-click selected you no longer see the stage move |
another feature request that might as well go in here: I can imagine wanting the position indicator to have 4 possible states:
|
I'm thinking that this widget might eventually gain so many configurations, that might be worth having a whole ExplorerConfig class: class ExplorerConfig:
auto_zoom_to_fit: bool = False
snap_on_double_click: bool = False
show_position: Literal[None, 'outline', 'crosshairs', 'crosshairs-with-outline']
clims: tuple | None
colormap (but just thinking out loud... not entirely sure yet) |
Yes, exactly...is related to #410 and is because we need to call Screen.Recording.2025-05-03.at.8.52.50.PM.mov |
That’s a great idea! I attempted to implement something along those lines: Screen.Recording.2025-05-04.at.12.52.47.AM.movAnd I agree, it would be good to have an |
this is just lovely. :) i pushed a few small organizational updates in dc07ae3. will keep looking |
src/pymmcore_widgets/control/_stage_explorer/_stage_position_marker.py
Outdated
Show resolved
Hide resolved
ok, i just merged it in. we can undo 58ebde9 (or parts of it) if you find issues with it. |
i also got rid of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and, if you're happy with it, go ahead and merge (not worried about the last little bit of test coverage)
Third part of the stage explore widget (#400 ) after #420.
Here we add a stage marker to track the position of the microscope stage.
TODO: