Skip to content

[Docs] Move Message definition to separate section, add extra options #6947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 17, 2022
Merged

[Docs] Move Message definition to separate section, add extra options #6947

merged 7 commits into from
Jun 17, 2022

Conversation

matusvalo
Copy link
Collaborator

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
✓ 📜 Docs

Description

A followup of #6693. It moves Message definition to separate section and adds documentation of extra options.

@matusvalo
Copy link
Collaborator Author

Marked as draft until #6693 is merged.

@matusvalo matusvalo mentioned this pull request Jun 13, 2022
Merged
Pierre-Sassoulas
Pierre-Sassoulas reviewed Jun 13, 2022
View reviewed changes
@coveralls
Copy link

coveralls commented Jun 13, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2513494676

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.548%
Totals Coverage Status
Change from base Build 2509577031: 0.0%
Covered Lines: 16440
Relevant Lines: 17206
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas reviewed Jun 14, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a suggestion, let me know what you think :) It's higly possible that "interpolled" is not a valid spelling maybe we could use printf / cstyle formatting.

@matusvalo matusvalo marked this pull request as ready for review June 16, 2022 09:33
@matusvalo
Copy link
Collaborator Author

Marking as ready to review since #6693 is merged. There are some open comments and failing tests. I will review them later on.

@matusvalo @Pierre-Sassoulas
Apply suggestions from code review
c614a07 
Co-authored-by: Pierre Sassoulas <[email protected]>
@jacobtylerwalls jacobtylerwalls changed the title [Docs] Move Message difinition to separate section, add extra options [Docs] Move Message definition to separate section, add extra options Jun 16, 2022
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@matusvalo matusvalo merged commit ee24a8f into main Jun 17, 2022
@matusvalo matusvalo deleted the extra_options branch June 17, 2022 05:37
@Pierre-Sassoulas
Copy link
Member

Just a nitpick @matusvalo, could you rewrite the commit message when squashing ? It gets pretty dirty otherwise :)

@matusvalo
Copy link
Collaborator Author

OK I will, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord Awaiting requested review from DanielNoord

Assignees
No one assigned
Labels
Documentation 📗
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matusvalo @coveralls @Pierre-Sassoulas @DanielNoord