Skip to content

fix imgui example #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix imgui example #711

wants to merge 2 commits into from

Conversation

Vipitis
Copy link
Contributor

@Vipitis Vipitis commented May 2, 2025

tiny issue I encountered with one of the examples, seems to be from #706

not sure if this is 100% the correct way but it seems to mostly work. The odd part is that I was able to run this example a few days ago on my other machine which I strongly think was on main branch already...

@Vipitis Vipitis requested a review from Korijn as a code owner May 2, 2025 17:47
@Vipitis
Copy link
Contributor Author

Vipitis commented May 5, 2025

I should probably add a docstrings to the .render method too... Just saw that, will update the PR in maybe two days when I am back

almarklein
almarklein previously approved these changes May 5, 2025
@panxinmiao
Copy link
Contributor

Uh, I feel the psize parameter is a bit odd, and it might be inconsistent with the state of draw_data... 🤔

@Korijn
Copy link
Collaborator

Korijn commented May 7, 2025

Is this PR still needed now that #713 is merged?

@Vipitis
Copy link
Contributor Author

Vipitis commented May 7, 2025

no, it's no longer needed

@Vipitis Vipitis closed this May 7, 2025
@Vipitis Vipitis deleted the fix-example branch May 7, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants