Skip to content

[TC-CLCTRL-4.4] test script steps. #38567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fabian-imig
Copy link

@fabian-imig fabian-imig commented Apr 24, 2025

Adds the python script to test the testcase TC-CLCTRL-4.4 against the closure-app.
This test case verifies the behavior of the CountdownTime attribute during MoveTo operations.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Python test script for testing the ClosureControl cluster countdown time behavior in various operational scenarios.

  • Adds a new test class (TC_CLCTRL_4_4) with multiple defined test steps.
  • Implements asynchronous test functions to check attribute values under different movement operations.

@AliTalebVelux
Copy link

This test script will be validated once the app is finished and added to the CI at the same time.

Copy link
Contributor

@mkardous-silabs mkardous-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The steps for the test plan the script implements don't match with the implementation.
If this was implemented after test plan changes, the script might need to be updated.

attribute_list = await self.read_clctrl_attribute_expect_success(endpoint=endpoint, attribute=Clusters.ClosureControl.Attributes.AttributeList)

self.step("2b")
countdown_time_supported = Clusters.ClosureControl.Attributes.CountdownTime.attribute_id in attribute_list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
countdown_time_supported = Clusters.ClosureControl.Attributes.CountdownTime.attribute_id in attribute_list
countdown_time_supported = Clusters.ClosureControl.Attributes.CountdownTime.attribute_id in attribute_list
Suggested change
countdown_time_supported = Clusters.ClosureControl.Attributes.CountdownTime.attribute_id in attribute_list
is_countdown_time_supported = Clusters.ClosureControl.Attributes.CountdownTime.attribute_id in attribute_list

Comment on lines +109 to +114
feature_map = await self.read_clctrl_attribute_expect_success(endpoint=endpoint, attribute=Clusters.ClosureControl.Attributes.FeatureMap)
is_ps_feature_supported = feature_map & Clusters.ClosureControl.Bitmaps.Feature.kPosition

if not is_ps_feature_supported:
logging.info("Positioning feature not supported, skipping remaining test steps")
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't in the test plan.


self.step("4b")
# Wait to ensure any previous movement is complete
time.sleep(full_motion_duration)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make more sense to use the MouvementCompete event for this

@fabian-imig fabian-imig marked this pull request as draft April 25, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants