-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[TC-CLCTRL-2.1] test script steps. #38560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new Python test script for the ClosureControl cluster (TC-CLCTRL-2.1) that verifies proper attribute reading and range validations. Key changes include:
- Implementation of test steps covering commissioning, attribute list reading, and attribute value validations.
- Detailed checks for attributes such as CountdownTime, MainState, CurrentErrorList, OverallState, and OverallTarget.
- Logging and assertions to ensure the attribute values are within expected ranges.
Comments suppressed due to low confidence (2)
src/python_testing/TC_CLCTRL_2_1.py:138
- Consider adding a test case to cover the scenario where overall_state is None so that the behavior of the else branch is verified.
logging.info("OverallState is NULL, skipping steps")
src/python_testing/TC_CLCTRL_2_1.py:163
- Consider adding a test case to validate the branch handling when overall_target is None to ensure comprehensive test coverage.
logging.info("OverallTarget is NULL, skipping steps")
This test script will be validated once the app is finished and added to the CI at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test plan, for steps 6 and 7, use the featuremap PICS as the way to determine if a check should be done or not.
The test plan uses the feature map configured on the device to this instead. Both ways are acceptable, but we nee dto make sure the test plan matchs the script implementation.
PR #38560: Size comparison from f28fd9a to e80cbbc Full report (3 builds for cc32xx, stm32)
|
Adds the python script to test the testcase TC-CLCTRL-2.1 against the closure-app.
The testcase validates the attributes of the closure-control-cluster.