Skip to content

[TC-CLCTRL-2.1] test script steps. #38560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

fabian-imig
Copy link

@fabian-imig fabian-imig commented Apr 24, 2025

Adds the python script to test the testcase TC-CLCTRL-2.1 against the closure-app.
The testcase validates the attributes of the closure-control-cluster.

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Python test script for the ClosureControl cluster (TC-CLCTRL-2.1) that verifies proper attribute reading and range validations. Key changes include:

  • Implementation of test steps covering commissioning, attribute list reading, and attribute value validations.
  • Detailed checks for attributes such as CountdownTime, MainState, CurrentErrorList, OverallState, and OverallTarget.
  • Logging and assertions to ensure the attribute values are within expected ranges.
Comments suppressed due to low confidence (2)

src/python_testing/TC_CLCTRL_2_1.py:138

  • Consider adding a test case to cover the scenario where overall_state is None so that the behavior of the else branch is verified.
            logging.info("OverallState is NULL, skipping steps")

src/python_testing/TC_CLCTRL_2_1.py:163

  • Consider adding a test case to validate the branch handling when overall_target is None to ensure comprehensive test coverage.
            logging.info("OverallTarget is NULL, skipping steps")

@AliTalebVelux
Copy link

This test script will be validated once the app is finished and added to the CI at the same time.

Copy link
Contributor

@mkardous-silabs mkardous-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test plan, for steps 6 and 7, use the featuremap PICS as the way to determine if a check should be done or not.

The test plan uses the feature map configured on the device to this instead. Both ways are acceptable, but we nee dto make sure the test plan matchs the script implementation.

Copy link

PR #38560: Size comparison from f28fd9a to e80cbbc

Full report (3 builds for cc32xx, stm32)
platform target config section f28fd9a e80cbbc change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 544194 544226 32 0.0
RAM 205160 205160 0 0.0
lock CC3235SF_LAUNCHXL FLASH 578182 578538 356 0.1
RAM 205408 205440 32 0.0
stm32 light STM32WB5MM-DK FLASH 464440 464456 16 0.0
RAM 141504 141504 0 0.0

Copy link

PR #38560: Size comparison from f28fd9a to 2aaaa58

Full report (1 build for stm32)
platform target config section f28fd9a 2aaaa58 change % change
stm32 light STM32WB5MM-DK FLASH 464440 464456 16 0.0
RAM 141504 141504 0 0.0

@fabian-imig fabian-imig marked this pull request as draft April 25, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants