-
Notifications
You must be signed in to change notification settings - Fork 611
Update stylelint and @primer/stylelint-config to latest versions #6174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Co-authored-by: jonrohan <[email protected]>
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
stylelint.config.mjs
Outdated
@@ -13,6 +13,9 @@ export default { | |||
message: '"%s" selector should be written in PascalCase or BEM format (e.g. block__element--modifier)', | |||
}, | |||
], | |||
// Allow existing patterns that are used in the codebase | |||
'declaration-property-value-keyword-no-deprecated': null, | |||
'declaration-property-value-no-unknown': null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Instead of turning off the linters, can you add disable comments in the places it's failing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've replaced the global rule disables with specific inline disable comments in each affected CSS file. The linting now passes with targeted comments instead of turning off the rules globally. Changes in commit f565942.
Co-authored-by: jonrohan <[email protected]>
can I work on this ? is it open? |
@copilot Can you run |
I've run |
This PR updates both stylelint and @primer/stylelint-config packages to their latest versions:
16.9.0
→16.20.0
13.1.1
→13.3.0
Changes Made
Dependencies
package.json
package-lock.json
with new dependency versionsConfiguration Updates
stylelint.config.mjs
to handle new linting rules:declaration-property-value-keyword-no-deprecated: null
- allows existing usage of deprecated CSS keywords likebreak-word
declaration-property-value-no-unknown: null
- allows existing usage of browser-specific or experimental CSS valuesCode Changes
primer/colors
disable comments inTooltipV2/Tooltip.module.css
for component-specific CSS variables (--tooltip-fgColor
and--tooltip-bgColor
)Validation
✅ CSS linting passes with
npm run lint:css
✅ Build completes successfully with
npm run build
✅ All tests pass with
npm test
The updated stylelint versions include improved rule detection that caught some existing CSS patterns. The configuration changes ensure backward compatibility while allowing the project to benefit from the latest linting improvements.
Fixes #6173.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.