Skip to content

chore: update script to use migrated #6166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

joshblack
Copy link
Member

Noticed that we were reporting notMigrated for both 😅 This PR updates our script to use migrated instead.

@joshblack joshblack requested review from jonrohan and Copilot June 4, 2025 16:29
@joshblack joshblack requested a review from a team as a code owner June 4, 2025 16:29
@joshblack joshblack added the skip changeset This change does not need a changelog label Jun 4, 2025
Copy link

changeset-bot bot commented Jun 4, 2025

⚠️ No Changeset found

Latest commit: eb067b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack enabled auto-merge June 4, 2025 16:29
@github-actions github-actions bot added the staff Author is a staff member label Jun 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the migration-status script to list files from the migrated array rather than the notMigrated array.

  • Changed the loop to iterate over migrated instead of notMigrated
  • The table now correctly outputs paths and sizes of migrated files
Comments suppressed due to low confidence (1)

script/styled-components-migration-status.mts:91

  • The header message still says 'files that do not include styled-components' but is counting migrated files. Update this to accurately describe the migrated file list (e.g., 'files that have been migrated').
There are ${migrated.length} files that do not include styled-components in Prim

Copy link
Contributor

github-actions bot commented Jun 4, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 94.51 KB (0%)
packages/react/dist/browser.umd.js 94.64 KB (0%)

@joshblack joshblack added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit 919acfe Jun 11, 2025
33 of 34 checks passed
@joshblack joshblack deleted the chore/update-migration-script-to-report-not-migrated branch June 11, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants