-
Notifications
You must be signed in to change notification settings - Fork 611
ActionList: Add new prop disableFocusZone
#6116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5f38528 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
showDividers = false, | ||
role, | ||
sx: sxProp = defaultSxProp, | ||
disableFocusZone = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could instead add a prop named focusZoneSettings
, which allows consumers to customize the focus zone. This would work much like how it does in AnchoredOverlay
.
This might not be needed now, but gives consumers more flexibility with the component, and removes the need for the disableFocusZone
boolean prop.
Closes https://github.com/github/primer/issues/5227
Changelog
New
disableFocusZone
which allows consumers to disable thefocusZone
that is applied to theActionList
componentRollout strategy
Testing & Reviewing
Merge checklist