-
Notifications
You must be signed in to change notification settings - Fork 611
Added a few fixes to Code Connect after adjusting Figma property names #6110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates Figma Code Connect configurations to align with renamed Figma property names and refactors the Blankslate connector for consolidated props and added size variants.
- Renamed
leadingIcon
→leadingVisual
in UnderlinePanels and UnderlineNav connectors - Updated prop naming for ToggleSwitch (
labelposition
→statusLabelPosition
) and BranchName (type
→as
) - Refactored Blankslate connector to extract a shared
props
object, introduce asize
enum, and adjust variants
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
packages/react/src/experimental/UnderlinePanels/UnderlinePanels.figma.tsx | Renamed Figma prop leadingIcon? → leadingVisual? and updated variant keys |
packages/react/src/UnderlineNav/UnderlineNav.figma.tsx | Renamed Figma prop leadingIcon? → leadingVisual? |
packages/react/src/ToggleSwitch/ToggleSwitch.figma.tsx | Renamed labelposition → statusLabelPosition |
packages/react/src/BranchName/BranchName.figma.tsx | Renamed enum key 'type' → 'as' |
packages/react/src/Blankslate/Blankslate.figma.tsx | Extracted shared props , added size enum, refactored variants |
Comments suppressed due to low confidence (3)
packages/react/src/experimental/UnderlinePanels/UnderlinePanels.figma.tsx:43
- The example destructures
leadingIcon
but the prop was renamed toleadingVisual
. Update the parameter to{leadingVisual}
and useleadingVisual.fn
.
example: ({label, selected, leadingIcon}) => (
packages/react/src/experimental/UnderlinePanels/UnderlinePanels.figma.tsx:57
- The example still uses
leadingIcon
. It should destructureleadingVisual
and passleadingVisual.fn
to theicon
prop.
example: ({label, selected, leadingIcon, counterProps}) => (
packages/react/src/Blankslate/Blankslate.figma.tsx:8
- The new
size
prop is introduced but there are no corresponding tests validating the component across its size variants.
size: figma.enum('size', {
size-limit report 📦
|
Added a few fixes to Code Connect after adjusting Figma property names
Changelog
New
Changed
Removed
Rollout strategy
No impact on react, just code connect.
Testing & Reviewing
Merge checklist