Skip to content

Added a few fixes to Code Connect after adjusting Figma property names #6110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented May 22, 2025

Added a few fixes to Code Connect after adjusting Figma property names

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

No impact on react, just code connect.

Testing & Reviewing

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings May 22, 2025 08:00
@lukasoppermann lukasoppermann requested a review from a team as a code owner May 22, 2025 08:00
@lukasoppermann lukasoppermann added the skip changeset This change does not need a changelog label May 22, 2025
@lukasoppermann lukasoppermann requested a review from jonrohan May 22, 2025 08:00
Copy link

changeset-bot bot commented May 22, 2025

⚠️ No Changeset found

Latest commit: 809043c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 22, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Figma Code Connect configurations to align with renamed Figma property names and refactors the Blankslate connector for consolidated props and added size variants.

  • Renamed leadingIconleadingVisual in UnderlinePanels and UnderlineNav connectors
  • Updated prop naming for ToggleSwitch (labelpositionstatusLabelPosition) and BranchName (typeas)
  • Refactored Blankslate connector to extract a shared props object, introduce a size enum, and adjust variants

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/react/src/experimental/UnderlinePanels/UnderlinePanels.figma.tsx Renamed Figma prop leadingIcon?leadingVisual? and updated variant keys
packages/react/src/UnderlineNav/UnderlineNav.figma.tsx Renamed Figma prop leadingIcon?leadingVisual?
packages/react/src/ToggleSwitch/ToggleSwitch.figma.tsx Renamed labelpositionstatusLabelPosition
packages/react/src/BranchName/BranchName.figma.tsx Renamed enum key 'type''as'
packages/react/src/Blankslate/Blankslate.figma.tsx Extracted shared props, added size enum, refactored variants
Comments suppressed due to low confidence (3)

packages/react/src/experimental/UnderlinePanels/UnderlinePanels.figma.tsx:43

  • The example destructures leadingIcon but the prop was renamed to leadingVisual. Update the parameter to {leadingVisual} and use leadingVisual.fn.
example: ({label, selected, leadingIcon}) => (

packages/react/src/experimental/UnderlinePanels/UnderlinePanels.figma.tsx:57

  • The example still uses leadingIcon. It should destructure leadingVisual and pass leadingVisual.fn to the icon prop.
example: ({label, selected, leadingIcon, counterProps}) => (

packages/react/src/Blankslate/Blankslate.figma.tsx:8

  • The new size prop is introduced but there are no corresponding tests validating the component across its size variants.
size: figma.enum('size', {

Copy link
Contributor

github-actions bot commented May 22, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 94.42 KB (0%)
packages/react/dist/browser.umd.js 94.48 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants