Skip to content

Fail PR on contrast check fail #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2024
Merged

Fail PR on contrast check fail #890

merged 1 commit into from
Apr 16, 2024

Conversation

lukasoppermann
Copy link
Contributor

Summary

This PR adds a summary to the contrast check action and makes it fail if any contrast checks fail

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Apr 16, 2024
@lukasoppermann lukasoppermann requested review from a team as code owners April 16, 2024 13:17
@lukasoppermann lukasoppermann requested a review from jonrohan April 16, 2024 13:17
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d303f9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

Variables changed 
No variables changed

@github-actions GitHub Actions
Copy link
Contributor

Design Token Contrast Check

light: ✅ all checks passed

Show results table for theme: light
contrastPair pass contrastRatio minimumContrastRatio
fgColor-default vs. bgColor-default ✅ 15.79:1 4.5:1
fgColor-muted vs. bgColor-default ✅ 5.33:1 4.5:1
fgColor-default vs. bgColor-muted ✅ 14.83:1 4.5:1
fgColor-muted vs. bgColor-muted ✅ 5.01:1 4.5:1
fgColor-default vs. bgColor-inset ✅ 14.83:1 4.5:1
fgColor-muted vs. bgColor-inset ✅ 5.01:1 4.5:1
fgColor-default vs. bgColor-accent-muted ✅ 13.88:1 4.5:1
fgColor-default vs. bgColor-success-muted ✅ 14.19:1 4.5:1
fgColor-default vs. bgColor-open-muted ✅ 14.19:1 4.5:1
fgColor-default vs. bgColor-danger-muted ✅ 13.77:1 4.5:1
fgColor-default vs. bgColor-closed-muted ✅ 13.77:1 4.5:1
fgColor-default vs. bgColor-attention-muted ✅ 14.65:1 4.5:1
fgColor-default vs. bgColor-severe-muted ✅ 14.26:1 4.5:1
fgColor-default vs. bgColor-done-muted ✅ 14.21:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted ✅ 14.24:1 4.5:1
fgColor-accent vs. bgColor-default ✅ 5.19:1 4.5:1
fgColor-accent vs. bgColor-muted ✅ 4.87:1 4.5:1
fgColor-accent vs. bgColor-inset ✅ 4.87:1 4.5:1
fgColor-success vs. bgColor-default ✅ 5.07:1 4.5:1
fgColor-success vs. bgColor-muted ✅ 4.77:1 4.5:1
fgColor-success vs. bgColor-inset ✅ 4.77:1 4.5:1
fgColor-open vs. bgColor-default ✅ 5.07:1 4.5:1
fgColor-open vs. bgColor-muted ✅ 4.77:1 4.5:1
fgColor-open vs. bgColor-inset ✅ 4.77:1 4.5:1
fgColor-danger vs. bgColor-default ✅ 5.24:1 4.5:1
fgColor-danger vs. bgColor-muted ✅ 4.92:1 4.5:1
fgColor-danger vs. bgColor-inset ✅ 4.92:1 4.5:1
fgColor-closed vs. bgColor-default ✅ 5.24:1 4.5:1
fgColor-closed vs. bgColor-muted ✅ 4.92:1 4.5:1
fgColor-closed vs. bgColor-inset ✅ 4.92:1 4.5:1
fgColor-attention vs. bgColor-default ✅ 4.86:1 4.5:1
fgColor-attention vs. bgColor-muted ✅ 4.57:1 4.5:1
fgColor-attention vs. bgColor-inset ✅ 4.57:1 4.5:1
fgColor-severe vs. bgColor-default ✅ 5.03:1 4.5:1
fgColor-severe vs. bgColor-muted ✅ 4.72:1 4.5:1
fgColor-severe vs. bgColor-inset ✅ 4.72:1 4.5:1
fgColor-done vs. bgColor-default ✅ 5.04:1 4.5:1
fgColor-done vs. bgColor-muted ✅ 4.73:1 4.5:1
fgColor-done vs. bgColor-inset ✅ 4.73:1 4.5:1
fgColor-sponsors vs. bgColor-default ✅ 5.04:1 4.5:1
fgColor-sponsors vs. bgColor-muted ✅ 4.73:1 4.5:1
fgColor-sponsors vs. bgColor-inset ✅ 4.73:1 4.5:1
fgColor-accent vs. bgColor-accent-muted ✅ 4.56:1 4.5:1
fgColor-success vs. bgColor-success-muted ✅ 4.56:1 4.5:1
fgColor-open vs. bgColor-open-muted ✅ 4.56:1 4.5:1
fgColor-danger vs. bgColor-danger-muted ✅ 4.57:1 4.5:1
fgColor-closed vs. bgColor-closed-muted ✅ 4.57:1 4.5:1
fgColor-attention vs. bgColor-attention-muted ✅ 4.51:1 4.5:1
fgColor-severe vs. bgColor-severe-muted ✅ 4.54:1 4.5:1
fgColor-done vs. bgColor-done-muted ✅ 4.53:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted ✅ 4.55:1 4.5:1
fgColor-onEmphasis vs. bgColor-neutral-emphasis ✅ 4.54:1 4.5:1
fgColor-onEmphasis vs. bgColor-accent-emphasis ✅ 5.19:1 4.5:1
fgColor-onEmphasis vs. bgColor-success-emphasis ✅ 4.51:1 4.5:1
fgColor-onEmphasis vs. bgColor-open-emphasis ✅ 4.51:1 4.5:1
fgColor-onEmphasis vs. bgColor-danger-emphasis ✅ 5.35:1 4.5:1
fgColor-onEmphasis vs. bgColor-closed-emphasis ✅ 5.35:1 4.5:1
fgColor-onEmphasis vs. bgColor-attention-emphasis ✅ 4.86:1 4.5:1
fgColor-onEmphasis vs. bgColor-severe-emphasis ✅ 5.03:1 4.5:1
fgColor-onEmphasis vs. bgColor-done-emphasis ✅ 5.04:1 4.5:1
fgColor-onEmphasis vs. bgColor-sponsors-emphasis ✅ 5.04:1 4.5:1
control-borderColor-emphasis vs. bgColor-default ✅ 3.27:1 3:1
control-borderColor-emphasis vs. bgColor-muted ✅ 3.08:1 3:1

dark: ❌ 29 checks failed

Show results table for theme: dark
contrastPair pass contrastRatio minimumContrastRatio
fgColor-default vs. bgColor-default ❌ 1.18:1 4.5:1
fgColor-muted vs. bgColor-default ❌ 3.36:1 4.5:1
fgColor-default vs. bgColor-muted ✅ 14.63:1 4.5:1
fgColor-muted vs. bgColor-muted ✅ 5.13:1 4.5:1
fgColor-default vs. bgColor-inset ✅ 17.37:1 4.5:1
fgColor-muted vs. bgColor-inset ✅ 6.1:1 4.5:1
fgColor-default vs. bgColor-accent-muted on bgColor-default ❌ 1.05:1 4.5:1
fgColor-default vs. bgColor-accent-muted on bgColor-muted ✅ 12.91:1 4.5:1
fgColor-default vs. bgColor-success-muted on bgColor-default ❌ 1:1 4.5:1
fgColor-default vs. bgColor-success-muted on bgColor-muted ✅ 12:1 4.5:1
fgColor-default vs. bgColor-open-muted on bgColor-default ❌ 1.05:1 4.5:1
fgColor-default vs. bgColor-open-muted on bgColor-muted ✅ 12.85:1 4.5:1
fgColor-default vs. bgColor-danger-muted on bgColor-default ❌ 1.04:1 4.5:1
fgColor-default vs. bgColor-danger-muted on bgColor-muted ✅ 13.09:1 4.5:1
fgColor-default vs. bgColor-closed-muted on bgColor-default ❌ 1.01:1 4.5:1
fgColor-default vs. bgColor-closed-muted on bgColor-muted ✅ 12.34:1 4.5:1
fgColor-default vs. bgColor-attention-muted on bgColor-default ❌ 1:1 4.5:1
fgColor-default vs. bgColor-attention-muted on bgColor-muted ✅ 12.08:1 4.5:1
fgColor-default vs. bgColor-severe-muted on bgColor-default ❌ 1.05:1 4.5:1
fgColor-default vs. bgColor-severe-muted on bgColor-muted ✅ 13.03:1 4.5:1
fgColor-default vs. bgColor-done-muted on bgColor-default ❌ 1.02:1 4.5:1
fgColor-default vs. bgColor-done-muted on bgColor-muted ✅ 11.71:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted on bgColor-default ❌ 1.05:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted on bgColor-muted ✅ 12.98:1 4.5:1
fgColor-accent vs. bgColor-default ❌ 3.09:1 4.5:1
fgColor-accent vs. bgColor-muted ✅ 5.58:1 4.5:1
fgColor-accent vs. bgColor-inset ✅ 6.62:1 4.5:1
fgColor-success vs. bgColor-default ❌ 2.54:1 4.5:1
fgColor-success vs. bgColor-muted ✅ 6.8:1 4.5:1
fgColor-success vs. bgColor-inset ✅ 8.08:1 4.5:1
fgColor-open vs. bgColor-default ❌ 2.54:1 4.5:1
fgColor-open vs. bgColor-muted ✅ 6.8:1 4.5:1
fgColor-open vs. bgColor-inset ✅ 8.08:1 4.5:1
fgColor-danger vs. bgColor-default ❌ 3.35:1 4.5:1
fgColor-danger vs. bgColor-muted ✅ 5.16:1 4.5:1
fgColor-danger vs. bgColor-inset ✅ 6.12:1 4.5:1
fgColor-closed vs. bgColor-default ❌ 3.35:1 4.5:1
fgColor-closed vs. bgColor-muted ✅ 5.16:1 4.5:1
fgColor-closed vs. bgColor-inset ✅ 6.12:1 4.5:1
fgColor-attention vs. bgColor-default ❌ 2.52:1 4.5:1
fgColor-attention vs. bgColor-muted ✅ 6.85:1 4.5:1
fgColor-attention vs. bgColor-inset ✅ 8.13:1 4.5:1
fgColor-severe vs. bgColor-default ❌ 3.37:1 4.5:1
fgColor-severe vs. bgColor-muted ✅ 5.13:1 4.5:1
fgColor-severe vs. bgColor-inset ✅ 6.09:1 4.5:1
fgColor-done vs. bgColor-default ❌ 2.99:1 4.5:1
fgColor-done vs. bgColor-muted ✅ 5.78:1 4.5:1
fgColor-done vs. bgColor-inset ✅ 6.86:1 4.5:1
fgColor-sponsors vs. bgColor-default ❌ 3.36:1 4.5:1
fgColor-sponsors vs. bgColor-muted ✅ 5.14:1 4.5:1
fgColor-sponsors vs. bgColor-inset ✅ 6.1:1 4.5:1
fgColor-accent vs. bgColor-accent-muted on bgColor-default ❌ 2.77:1 4.5:1
fgColor-success vs. bgColor-success-muted on bgColor-default ❌ 2.16:1 4.5:1
fgColor-success vs. bgColor-success-muted on bgColor-muted ✅ 5.58:1 4.5:1
fgColor-open vs. bgColor-open-muted on bgColor-default ❌ 2.27:1 4.5:1
fgColor-open vs. bgColor-open-muted on bgColor-muted ✅ 5.97:1 4.5:1
fgColor-danger vs. bgColor-danger-muted on bgColor-default ❌ 2.95:1 4.5:1
fgColor-danger vs. bgColor-danger-muted on bgColor-muted ✅ 4.61:1 4.5:1
fgColor-closed vs. bgColor-closed-muted on bgColor-default ❌ 2.8:1 4.5:1
fgColor-attention vs. bgColor-attention-muted on bgColor-default ❌ 2.15:1 4.5:1
fgColor-attention vs. bgColor-attention-muted on bgColor-muted ✅ 5.65:1 4.5:1
fgColor-severe vs. bgColor-severe-muted on bgColor-default ❌ 3:1 4.5:1
fgColor-severe vs. bgColor-severe-muted on bgColor-muted ✅ 4.57:1 4.5:1
fgColor-done vs. bgColor-done-muted on bgColor-default ❌ 2.59:1 4.5:1
fgColor-done vs. bgColor-done-muted on bgColor-muted ✅ 4.62:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted on bgColor-default ❌ 3:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted on bgColor-muted ✅ 4.56:1 4.5:1
fgColor-onEmphasis vs. bgColor-neutral-emphasis ✅ 4.59:1 4.5:1
fgColor-onEmphasis vs. bgColor-accent-emphasis ✅ 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-success-emphasis ✅ 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-open-emphasis ✅ 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-danger-emphasis ✅ 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-closed-emphasis ✅ 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-attention-emphasis ✅ 4.64:1 4.5:1
fgColor-onEmphasis vs. bgColor-severe-emphasis ✅ 4.65:1 4.5:1
fgColor-onEmphasis vs. bgColor-done-emphasis ✅ 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-sponsors-emphasis ✅ 4.57:1 4.5:1
control-borderColor-emphasis vs. bgColor-default ✅ 5.15:1 3:1
control-borderColor-emphasis vs. bgColor-muted ✅ 3.35:1 3:1

@github-actions GitHub Actions
Copy link
Contributor

Design Token Diff

/css/functional/themes/dark-colorblind.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-colorblind.css	2024-04-16 13:18:31.287134474 +0000
@@ -4,7 +4,7 @@
[data-color-mode="auto"][data-light-theme="dark_colorblind"] ::backdrop {
 --topicTag-borderColor: #00000000;
 --highlight-neutral-bgColor: #d2992266;
-  --page-header-bgColor: #0d1117;
+  --page-header-bgColor: #ffffff;
 --diffBlob-addition-fgColor-text: #e6edf3;
 --diffBlob-addition-fgColor-num: #e6edf3;
 --diffBlob-addition-bgColor-num: #58a6ff4d;
@@ -18,16 +18,16 @@
 --diffBlob-hunk-bgColor-num: #388bfd66;
 --diffBlob-expander-iconColor: #848d97;
 --codeMirror-fgColor: #e6edf3;
-  --codeMirror-bgColor: #0d1117;
-  --codeMirror-gutters-bgColor: #0d1117;
-  --codeMirror-gutterMarker-fgColor-default: #0d1117;
+  --codeMirror-bgColor: #ffffff;
+  --codeMirror-gutters-bgColor: #ffffff;
+  --codeMirror-gutterMarker-fgColor-default: #ffffff;
 --codeMirror-gutterMarker-fgColor-muted: #848d97;
 --codeMirror-lineNumber-fgColor: #848d97;
 --codeMirror-cursor-fgColor: #e6edf3;
 --codeMirror-selection-bgColor: #388bfd66;
 --codeMirror-activeline-bgColor: #6e768166;
 --codeMirror-matchingBracket-fgColor: #e6edf3;
-  --codeMirror-lines-bgColor: #0d1117;
+  --codeMirror-lines-bgColor: #ffffff;
 --codeMirror-syntax-fgColor-comment: #8b949e;
 --codeMirror-syntax-fgColor-constant: #79c0ff;
 --codeMirror-syntax-fgColor-entity: #d2a8ff;
@@ -421,7 +421,7 @@
 --fgColor-done: #ab7df8;
 --fgColor-upsell: #ab7df8;
 --fgColor-sponsors: #db61a2;
-  --bgColor-default: #0d1117;
+  --bgColor-default: #ffffff;
 --bgColor-muted: #161b22;
 --bgColor-inset: #010409;
 --bgColor-emphasis: #6e7681;
@@ -542,7 +542,7 @@
 [data-color-mode="auto"][data-dark-theme="dark_colorblind"] ::backdrop {
   --topicTag-borderColor: #00000000;
   --highlight-neutral-bgColor: #d2992266;
-    --page-header-bgColor: #0d1117;
+    --page-header-bgColor: #ffffff;
   --diffBlob-addition-fgColor-text: #e6edf3;
   --diffBlob-addition-fgColor-num: #e6edf3;
   --diffBlob-addition-bgColor-num: #58a6ff4d;
@@ -556,16 +556,16 @@
   --diffBlob-hunk-bgColor-num: #388bfd66;
   --diffBlob-expander-iconColor: #848d97;
   --codeMirror-fgColor: #e6edf3;
-    --codeMirror-bgColor: #0d1117;
-    --codeMirror-gutters-bgColor: #0d1117;
-    --codeMirror-gutterMarker-fgColor-default: #0d1117;
+    --codeMirror-bgColor: #ffffff;
+    --codeMirror-gutters-bgColor: #ffffff;
+    --codeMirror-gutterMarker-fgColor-default: #ffffff;
   --codeMirror-gutterMarker-fgColor-muted: #848d97;
   --codeMirror-lineNumber-fgColor: #848d97;
   --codeMirror-cursor-fgColor: #e6edf3;
   --codeMirror-selection-bgColor: #388bfd66;
   --codeMirror-activeline-bgColor: #6e768166;
   --codeMirror-matchingBracket-fgColor: #e6edf3;
-    --codeMirror-lines-bgColor: #0d1117;
+    --codeMirror-lines-bgColor: #ffffff;
   --codeMirror-syntax-fgColor-comment: #8b949e;
   --codeMirror-syntax-fgColor-constant: #79c0ff;
   --codeMirror-syntax-fgColor-entity: #d2a8ff;
@@ -959,7 +959,7 @@
   --fgColor-done: #ab7df8;
   --fgColor-upsell: #ab7df8;
   --fgColor-sponsors: #db61a2;
-    --bgColor-default: #0d1117;
+    --bgColor-default: #ffffff;
   --bgColor-muted: #161b22;
   --bgColor-inset: #010409;
   --bgColor-emphasis: #6e7681;

/css/functional/themes/dark-dimmed.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-dimmed.css	2024-04-16 13:18:30.031125924 +0000
@@ -4,7 +4,7 @@
[data-color-mode="auto"][data-light-theme="dark_dimmed"] ::backdrop {
 --topicTag-borderColor: #00000000;
 --highlight-neutral-bgColor: #c6902666;
-  --page-header-bgColor: #22272e;
+  --page-header-bgColor: #ffffff;
 --diffBlob-addition-fgColor-text: #c5d1de;
 --diffBlob-addition-fgColor-num: #c5d1de;
 --diffBlob-addition-bgColor-num: #57ab5a4d;
@@ -18,16 +18,16 @@
 --diffBlob-hunk-bgColor-num: #4184e466;
 --diffBlob-expander-iconColor: #c5d1de;
 --codeMirror-fgColor: #c5d1de;
-  --codeMirror-bgColor: #22272e;
-  --codeMirror-gutters-bgColor: #22272e;
-  --codeMirror-gutterMarker-fgColor-default: #22272e;
+  --codeMirror-bgColor: #ffffff;
+  --codeMirror-gutters-bgColor: #ffffff;
+  --codeMirror-gutterMarker-fgColor-default: #ffffff;
 --codeMirror-gutterMarker-fgColor-muted: #717e8b;
 --codeMirror-lineNumber-fgColor: #717e8b;
 --codeMirror-cursor-fgColor: #c5d1de;
 --codeMirror-selection-bgColor: #4184e466;
 --codeMirror-activeline-bgColor: #636e7b66;
 --codeMirror-matchingBracket-fgColor: #c5d1de;
-  --codeMirror-lines-bgColor: #22272e;
+  --codeMirror-lines-bgColor: #ffffff;
 --codeMirror-syntax-fgColor-comment: #768390;
 --codeMirror-syntax-fgColor-constant: #6cb6ff;
 --codeMirror-syntax-fgColor-entity: #dcbdfb;
@@ -421,7 +421,7 @@
 --fgColor-done: #986ee2;
 --fgColor-upsell: #986ee2;
 --fgColor-sponsors: #c96198;
-  --bgColor-default: #22272e;
+  --bgColor-default: #ffffff;
 --bgColor-muted: #2d333b;
 --bgColor-inset: #1c2128;
 --bgColor-emphasis: #636e7b;
@@ -542,7 +542,7 @@
 [data-color-mode="auto"][data-dark-theme="dark_dimmed"] ::backdrop {
   --topicTag-borderColor: #00000000;
   --highlight-neutral-bgColor: #c6902666;
-    --page-header-bgColor: #22272e;
+    --page-header-bgColor: #ffffff;
   --diffBlob-addition-fgColor-text: #c5d1de;
   --diffBlob-addition-fgColor-num: #c5d1de;
   --diffBlob-addition-bgColor-num: #57ab5a4d;
@@ -556,16 +556,16 @@
   --diffBlob-hunk-bgColor-num: #4184e466;
   --diffBlob-expander-iconColor: #c5d1de;
   --codeMirror-fgColor: #c5d1de;
-    --codeMirror-bgColor: #22272e;
-    --codeMirror-gutters-bgColor: #22272e;
-    --codeMirror-gutterMarker-fgColor-default: #22272e;
+    --codeMirror-bgColor: #ffffff;
+    --codeMirror-gutters-bgColor: #ffffff;
+    --codeMirror-gutterMarker-fgColor-default: #ffffff;
   --codeMirror-gutterMarker-fgColor-muted: #717e8b;
   --codeMirror-lineNumber-fgColor: #717e8b;
   --codeMirror-cursor-fgColor: #c5d1de;
   --codeMirror-selection-bgColor: #4184e466;
   --codeMirror-activeline-bgColor: #636e7b66;
   --codeMirror-matchingBracket-fgColor: #c5d1de;
-    --codeMirror-lines-bgColor: #22272e;
+    --codeMirror-lines-bgColor: #ffffff;
   --codeMirror-syntax-fgColor-comment: #768390;
   --codeMirror-syntax-fgColor-constant: #6cb6ff;
   --codeMirror-syntax-fgColor-entity: #dcbdfb;
@@ -959,7 +959,7 @@
   --fgColor-done: #986ee2;
   --fgColor-upsell: #986ee2;
   --fgColor-sponsors: #c96198;
-    --bgColor-default: #22272e;
+    --bgColor-default: #ffffff;
   --bgColor-muted: #2d333b;
   --bgColor-inset: #1c2128;
   --bgColor-emphasis: #636e7b;

/css/functional/themes/dark-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-high-contrast.css	2024-04-16 13:18:31.919138776 +0000
@@ -4,7 +4,7 @@
[data-color-mode="auto"][data-light-theme="dark_high_contrast"] ::backdrop {
 --topicTag-borderColor: #409eff;
 --highlight-neutral-bgColor: #f0b72f66;
-  --page-header-bgColor: #0a0c10;
+  --page-header-bgColor: #ffffff;
 --diffBlob-addition-fgColor-text: #0a0c10;
 --diffBlob-addition-fgColor-num: #fbfcfd;
 --diffBlob-addition-bgColor-num: #28d7514d;
@@ -18,16 +18,16 @@
 --diffBlob-hunk-bgColor-num: #5cacff66;
 --diffBlob-expander-iconColor: #fbfcfd;
 --codeMirror-fgColor: #fbfcfd;
-  --codeMirror-bgColor: #0a0c10;
-  --codeMirror-gutters-bgColor: #0a0c10;
-  --codeMirror-gutterMarker-fgColor-default: #0a0c10;
+  --codeMirror-bgColor: #ffffff;
+  --codeMirror-gutters-bgColor: #ffffff;
+  --codeMirror-gutterMarker-fgColor-default: #ffffff;
 --codeMirror-gutterMarker-fgColor-muted: #f0f3f6;
 --codeMirror-lineNumber-fgColor: #f0f3f6;
 --codeMirror-cursor-fgColor: #fbfcfd;
 --codeMirror-selection-bgColor: #5cacff66;
 --codeMirror-activeline-bgColor: #9ea7b366;
 --codeMirror-matchingBracket-fgColor: #fbfcfd;
-  --codeMirror-lines-bgColor: #0a0c10;
+  --codeMirror-lines-bgColor: #ffffff;
 --codeMirror-syntax-fgColor-comment: #bdc4cc;
 --codeMirror-syntax-fgColor-constant: #91cbff;
 --codeMirror-syntax-fgColor-entity: #dbb7ff;
@@ -421,7 +421,7 @@
 --fgColor-done: #bf8fff;
 --fgColor-upsell: #bf8fff;
 --fgColor-sponsors: #f87cbd;
-  --bgColor-default: #0a0c10;
+  --bgColor-default: #ffffff;
 --bgColor-muted: #272b33;
 --bgColor-inset: #010409;
 --bgColor-emphasis: #ffffff;
@@ -542,7 +542,7 @@
 [data-color-mode="auto"][data-dark-theme="dark_high_contrast"] ::backdrop {
   --topicTag-borderColor: #409eff;
   --highlight-neutral-bgColor: #f0b72f66;
-    --page-header-bgColor: #0a0c10;
+    --page-header-bgColor: #ffffff;
   --diffBlob-addition-fgColor-text: #0a0c10;
   --diffBlob-addition-fgColor-num: #fbfcfd;
   --diffBlob-addition-bgColor-num: #28d7514d;
@@ -556,16 +556,16 @@
   --diffBlob-hunk-bgColor-num: #5cacff66;
   --diffBlob-expander-iconColor: #fbfcfd;
   --codeMirror-fgColor: #fbfcfd;
-    --codeMirror-bgColor: #0a0c10;
-    --codeMirror-gutters-bgColor: #0a0c10;
-    --codeMirror-gutterMarker-fgColor-default: #0a0c10;
+    --codeMirror-bgColor: #ffffff;
+    --codeMirror-gutters-bgColor: #ffffff;
+    --codeMirror-gutterMarker-fgColor-default: #ffffff;
   --codeMirror-gutterMarker-fgColor-muted: #f0f3f6;
   --codeMirror-lineNumber-fgColor: #f0f3f6;
   --codeMirror-cursor-fgColor: #fbfcfd;
   --codeMirror-selection-bgColor: #5cacff66;
   --codeMirror-activeline-bgColor: #9ea7b366;
   --codeMirror-matchingBracket-fgColor: #fbfcfd;
-    --codeMirror-lines-bgColor: #0a0c10;
+    --codeMirror-lines-bgColor: #ffffff;
   --codeMirror-syntax-fgColor-comment: #bdc4cc;
   --codeMirror-syntax-fgColor-constant: #91cbff;
   --codeMirror-syntax-fgColor-entity: #dbb7ff;
@@ -959,7 +959,7 @@
   --fgColor-done: #bf8fff;
   --fgColor-upsell: #bf8fff;
   --fgColor-sponsors: #f87cbd;
-    --bgColor-default: #0a0c10;
+    --bgColor-default: #ffffff;
   --bgColor-muted: #272b33;
   --bgColor-inset: #010409;
   --bgColor-emphasis: #ffffff;

/css/functional/themes/dark-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-tritanopia.css	2024-04-16 13:18:30.663130226 +0000
@@ -4,7 +4,7 @@
[data-color-mode="auto"][data-light-theme="dark_tritanopia"] ::backdrop {
 --topicTag-borderColor: #00000000;
 --highlight-neutral-bgColor: #d2992266;
-  --page-header-bgColor: #0d1117;
+  --page-header-bgColor: #ffffff;
 --diffBlob-addition-fgColor-text: #e6edf3;
 --diffBlob-addition-fgColor-num: #e6edf3;
 --diffBlob-addition-bgColor-num: #58a6ff4d;
@@ -18,16 +18,16 @@
 --diffBlob-hunk-bgColor-num: #388bfd66;
 --diffBlob-expander-iconColor: #848d97;
 --codeMirror-fgColor: #e6edf3;
-  --codeMirror-bgColor: #0d1117;
-  --codeMirror-gutters-bgColor: #0d1117;
-  --codeMirror-gutterMarker-fgColor-default: #0d1117;
+  --codeMirror-bgColor: #ffffff;
+  --codeMirror-gutters-bgColor: #ffffff;
+  --codeMirror-gutterMarker-fgColor-default: #ffffff;
 --codeMirror-gutterMarker-fgColor-muted: #848d97;
 --codeMirror-lineNumber-fgColor: #848d97;
 --codeMirror-cursor-fgColor: #e6edf3;
 --codeMirror-selection-bgColor: #388bfd66;
 --codeMirror-activeline-bgColor: #6e768166;
 --codeMirror-matchingBracket-fgColor: #e6edf3;
-  --codeMirror-lines-bgColor: #0d1117;
+  --codeMirror-lines-bgColor: #ffffff;
 --codeMirror-syntax-fgColor-comment: #8b949e;
 --codeMirror-syntax-fgColor-constant: #79c0ff;
 --codeMirror-syntax-fgColor-entity: #d2a8ff;
@@ -421,7 +421,7 @@
 --fgColor-done: #ab7df8;
 --fgColor-upsell: #ab7df8;
 --fgColor-sponsors: #db61a2;
-  --bgColor-default: #0d1117;
+  --bgColor-default: #ffffff;
 --bgColor-muted: #161b22;
 --bgColor-inset: #010409;
 --bgColor-emphasis: #6e7681;
@@ -542,7 +542,7 @@
 [data-color-mode="auto"][data-dark-theme="dark_tritanopia"] ::backdrop {
   --topicTag-borderColor: #00000000;
   --highlight-neutral-bgColor: #d2992266;
-    --page-header-bgColor: #0d1117;
+    --page-header-bgColor: #ffffff;
   --diffBlob-addition-fgColor-text: #e6edf3;
   --diffBlob-addition-fgColor-num: #e6edf3;
   --diffBlob-addition-bgColor-num: #58a6ff4d;
@@ -556,16 +556,16 @@
   --diffBlob-hunk-bgColor-num: #388bfd66;
   --diffBlob-expander-iconColor: #848d97;
   --codeMirror-fgColor: #e6edf3;
-    --codeMirror-bgColor: #0d1117;
-    --codeMirror-gutters-bgColor: #0d1117;
-    --codeMirror-gutterMarker-fgColor-default: #0d1117;
+    --codeMirror-bgColor: #ffffff;
+    --codeMirror-gutters-bgColor: #ffffff;
+    --codeMirror-gutterMarker-fgColor-default: #ffffff;
   --codeMirror-gutterMarker-fgColor-muted: #848d97;
   --codeMirror-lineNumber-fgColor: #848d97;
   --codeMirror-cursor-fgColor: #e6edf3;
   --codeMirror-selection-bgColor: #388bfd66;
   --codeMirror-activeline-bgColor: #6e768166;
   --codeMirror-matchingBracket-fgColor: #e6edf3;
-    --codeMirror-lines-bgColor: #0d1117;
+    --codeMirror-lines-bgColor: #ffffff;
   --codeMirror-syntax-fgColor-comment: #8b949e;
   --codeMirror-syntax-fgColor-constant: #79c0ff;
   --codeMirror-syntax-fgColor-entity: #d2a8ff;
@@ -959,7 +959,7 @@
   --fgColor-done: #ab7df8;
   --fgColor-upsell: #ab7df8;
   --fgColor-sponsors: #db61a2;
-    --bgColor-default: #0d1117;
+    --bgColor-default: #ffffff;
   --bgColor-muted: #161b22;
   --bgColor-inset: #010409;
   --bgColor-emphasis: #6e7681;

/css/functional/themes/dark.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark.css	2024-04-16 13:18:29.195120233 +0000
@@ -4,7 +4,7 @@
[data-color-mode="auto"][data-light-theme="dark"] ::backdrop {
 --topicTag-borderColor: #00000000;
 --highlight-neutral-bgColor: #d2992266;
-  --page-header-bgColor: #0d1117;
+  --page-header-bgColor: #ffffff;
 --diffBlob-addition-fgColor-text: #e6edf3;
 --diffBlob-addition-fgColor-num: #e6edf3;
 --diffBlob-addition-bgColor-num: #3fb9504d;
@@ -18,16 +18,16 @@
 --diffBlob-hunk-bgColor-num: #388bfd66;
 --diffBlob-expander-iconColor: #848d97;
 --codeMirror-fgColor: #e6edf3;
-  --codeMirror-bgColor: #0d1117;
-  --codeMirror-gutters-bgColor: #0d1117;
-  --codeMirror-gutterMarker-fgColor-default: #0d1117;
+  --codeMirror-bgColor: #ffffff;
+  --codeMirror-gutters-bgColor: #ffffff;
+  --codeMirror-gutterMarker-fgColor-default: #ffffff;
 --codeMirror-gutterMarker-fgColor-muted: #848d97;
 --codeMirror-lineNumber-fgColor: #848d97;
 --codeMirror-cursor-fgColor: #e6edf3;
 --codeMirror-selection-bgColor: #388bfd66;
 --codeMirror-activeline-bgColor: #6e768166;
 --codeMirror-matchingBracket-fgColor: #e6edf3;
-  --codeMirror-lines-bgColor: #0d1117;
+  --codeMirror-lines-bgColor: #ffffff;
 --codeMirror-syntax-fgColor-comment: #8b949e;
 --codeMirror-syntax-fgColor-constant: #79c0ff;
 --codeMirror-syntax-fgColor-entity: #d2a8ff;
@@ -421,7 +421,7 @@
 --fgColor-done: #ab7df8;
 --fgColor-upsell: #ab7df8;
 --fgColor-sponsors: #db61a2;
-  --bgColor-default: #0d1117;
+  --bgColor-default: #ffffff;
 --bgColor-muted: #161b22;
 --bgColor-inset: #010409;
 --bgColor-emphasis: #6e7681;
@@ -542,7 +542,7 @@
 [data-color-mode="auto"][data-dark-theme="dark"] ::backdrop {
   --topicTag-borderColor: #00000000;
   --highlight-neutral-bgColor: #d2992266;
-    --page-header-bgColor: #0d1117;
+    --page-header-bgColor: #ffffff;
   --diffBlob-addition-fgColor-text: #e6edf3;
   --diffBlob-addition-fgColor-num: #e6edf3;
   --diffBlob-addition-bgColor-num: #3fb9504d;
@@ -556,16 +556,16 @@
   --diffBlob-hunk-bgColor-num: #388bfd66;
   --diffBlob-expander-iconColor: #848d97;
   --codeMirror-fgColor: #e6edf3;
-    --codeMirror-bgColor: #0d1117;
-    --codeMirror-gutters-bgColor: #0d1117;
-    --codeMirror-gutterMarker-fgColor-default: #0d1117;
+    --codeMirror-bgColor: #ffffff;
+    --codeMirror-gutters-bgColor: #ffffff;
+    --codeMirror-gutterMarker-fgColor-default: #ffffff;
   --codeMirror-gutterMarker-fgColor-muted: #848d97;
   --codeMirror-lineNumber-fgColor: #848d97;
   --codeMirror-cursor-fgColor: #e6edf3;
   --codeMirror-selection-bgColor: #388bfd66;
   --codeMirror-activeline-bgColor: #6e768166;
   --codeMirror-matchingBracket-fgColor: #e6edf3;
-    --codeMirror-lines-bgColor: #0d1117;
+    --codeMirror-lines-bgColor: #ffffff;
   --codeMirror-syntax-fgColor-comment: #8b949e;
   --codeMirror-syntax-fgColor-constant: #79c0ff;
   --codeMirror-syntax-fgColor-entity: #d2a8ff;
@@ -959,7 +959,7 @@
   --fgColor-done: #ab7df8;
   --fgColor-upsell: #ab7df8;
   --fgColor-sponsors: #db61a2;
-    --bgColor-default: #0d1117;
+    --bgColor-default: #ffffff;
   --bgColor-muted: #161b22;
   --bgColor-inset: #010409;
   --bgColor-emphasis: #6e7681;

@github-actions github-actions bot temporarily deployed to storybook-preview April 16, 2024 13:19 Inactive
@lukasoppermann lukasoppermann force-pushed the fail-build-on-contrast-fail branch from b8f46cb to d303f9e Compare April 16, 2024 13:30
@github-actions github-actions bot temporarily deployed to storybook-preview April 16, 2024 13:33 Inactive
@lukasoppermann lukasoppermann merged commit 47bb2bf into main Apr 16, 2024
@lukasoppermann lukasoppermann deleted the fail-build-on-contrast-fail branch April 16, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasoppermann