Skip to content

Add labelColor #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

Add labelColor #1217

merged 3 commits into from
May 13, 2025

Conversation

lukasoppermann
Copy link
Contributor

Summary

List of notable changes:

What should reviewers focus on?

Steps to test:

@lukasoppermann lukasoppermann self-assigned this May 13, 2025
@Copilot Copilot AI review requested due to automatic review settings May 13, 2025 11:58
@lukasoppermann lukasoppermann requested review from a team as code owners May 13, 2025 11:58
@lukasoppermann lukasoppermann requested a review from langermank May 13, 2025 11:58
@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label May 13, 2025
Copy link

changeset-bot bot commented May 13, 2025

⚠️ No Changeset found

Latest commit: b301966

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Storybook pattern for label color tokens, rendering them as interactive chips and in a data table.

  • Imported Box and Token from @primer/react
  • Added Label story: maps label tokens to Token components and a DataTable for visualization
Comments suppressed due to low confidence (1)

docs/storybook/stories/Color/Patterns/AllPatterns.stories.tsx:890

  • The variable colorTokens is not defined in this file. You need to import or pass in the correct token list (e.g., import {colorTokens} from 'path/to/tokens') before using it.
const data = getTokensByName(colorTokens, 'label').map(token => {

@lukasoppermann lukasoppermann merged commit 7975d75 into main May 13, 2025
27 checks passed
@lukasoppermann lukasoppermann deleted the add-label-color-to-storybook branch May 13, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants