Skip to content

Fix font family to figma #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Fix font family to figma #1209

merged 1 commit into from
Apr 10, 2025

Conversation

lukasoppermann
Copy link
Contributor

Summary

Fix font family to Figma type tokens.

List of notable changes:

What should reviewers focus on?

Steps to test:

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Apr 10, 2025
@lukasoppermann lukasoppermann self-assigned this Apr 10, 2025
@lukasoppermann lukasoppermann requested review from a team as code owners April 10, 2025 08:08
@lukasoppermann lukasoppermann requested a review from jonrohan April 10, 2025 08:08
Copy link

changeset-bot bot commented Apr 10, 2025

⚠️ No Changeset found

Latest commit: 9164b98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Design Token Diff (Figma)

/figma/typography/typography.json

+++ /home/runner/work/primitives/primitives/dist/figma/typography/typography.json	2025-04-10 08:09:56.718077822 +0000
@@ -41,7 +41,7 @@
 },
 {
   "name": "fontStack/system",
-    "value": "-apple-system, BlinkMacSystemFont, 'Segoe UI', 'Noto Sans', Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji'",
+    "value": "SF Pro Text",
   "type": "STRING",
   "refId": "typography/fontStack/system",
   "collection": "typography",
@@ -51,7 +51,7 @@
 },
 {
   "name": "fontStack/sansSerif",
-    "value": "-apple-system, BlinkMacSystemFont, 'Segoe UI', 'Noto Sans', Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji'",
+    "value": "SF Pro Text",
   "type": "STRING",
   "refId": "typography/fontStack/sansSerif",
   "collection": "typography",
@@ -61,7 +61,7 @@
 },
 {
   "name": "fontStack/sansSerifDisplay",
-    "value": "-apple-system, BlinkMacSystemFont, 'Segoe UI', 'Noto Sans', Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji'",
+    "value": "SF Pro Display",
   "type": "STRING",
   "refId": "typography/fontStack/sansSerifDisplay",
   "collection": "typography",
@@ -71,7 +71,7 @@
 },
 {
   "name": "fontStack/monospace",
-    "value": "ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace",
+    "value": "SF Mono",
   "type": "STRING",
   "refId": "typography/fontStack/monospace",
   "collection": "typography",

@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 10, 2025 08:10 Inactive
@lukasoppermann lukasoppermann merged commit 9673e13 into main Apr 10, 2025
32 checks passed
@lukasoppermann lukasoppermann deleted the fix-font-family-figma branch April 10, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant