Skip to content

Staking Next Page #11483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Jun 19, 2025
Merged

Staking Next Page #11483

merged 43 commits into from
Jun 19, 2025

Conversation

ap211unitech
Copy link
Member

@ap211unitech ap211unitech commented Apr 15, 2025

📝 Description

This PR aims to create a new staking page (Staking Next) for Asset Hub migration. The main idea here is to add "Staking Next Command Center" and makes other tabs compatble with new storage/pallets.

The core implementation is done with this - https://hackmd.io/7PiBrGxxRG2ib-WRZYJZhQ and https://github.com/paritytech/polkadot-scripts/blob/51a99829460322be11379ea642f0642940604b1a/src/handlers.ts#L174

Screen.Recording.2025-06-09.at.09.07.11.mov

@ap211unitech ap211unitech self-assigned this May 8, 2025
@ap211unitech ap211unitech marked this pull request as ready for review May 11, 2025 18:05
@valentinfernandez1 valentinfernandez1 self-requested a review May 20, 2025 15:18
Copy link
Contributor

@valentinfernandez1 valentinfernandez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I have a few nip picks, please address them.

Copy link
Contributor

@valentinfernandez1 valentinfernandez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like a second pair of eyes, @TarikGul could you take a look?

@ap211unitech ap211unitech linked an issue Jun 6, 2025 that may be closed by this pull request
@kianenigma
Copy link

NICE!

Nit: we renamed this from Staking Next to Staking Async. Probably you want to do the same.

I will set some time aside to run this locally with @Ank4n. If you have any screenshots/demo vides in the meantime, that would be awesome.

@ap211unitech
Copy link
Member Author

Sure. I'll rename it. Also, I'll test it out on Westend testnet (Didn't got a chance to do it yet) and can paste a video here.

@kianenigma
Copy link

Great, also please keep paritytech/polkadot-sdk#8763 in mind. We messed some of the pallet names in westend, and we will rename them.

@ap211unitech
Copy link
Member Author

Hi Kian, I've renamed it to Staking Async now and attached a small video here. Tested on Westend, it seems to be working fine for now.

@kianenigma
Copy link

Very nice! let's wait for paritytech/polkadot-sdk#8801, and then merge this.

@Ank4n
Copy link
Contributor

Ank4n commented Jun 11, 2025

Hi Kian, I've renamed it to Staking Async now and attached a small video here. Tested on Westend, it seems to be working fine for now.

Can't load the video 🙃

@ap211unitech
Copy link
Member Author

ap211unitech commented Jun 12, 2025

Uploaded to G-Drive. Try this link.

@ap211unitech ap211unitech merged commit d449a24 into master Jun 19, 2025
5 checks passed
@ap211unitech ap211unitech deleted the feat/staking-next-page branch June 19, 2025 05:04
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Staking-next integration aka. "Staking Next Command Center"
6 participants