Skip to content

Enable binding workaround in release builds #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2025

Conversation

lukeredpath
Copy link
Contributor

The store will suppress warnings for invalid actions emitted by bindings to workaround a SwiftUI issue of bindings firing on dismissal when focussed, but only in debug builds.

We capture issues in release builds in Sentry so this can still be noisy and there doesn't seem to be any need to restrict this to just debug builds.

@lukeredpath lukeredpath changed the title fix: Enable binding workaround in release builds Enable binding workaround in release builds Apr 1, 2025
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephencelis stephencelis merged commit a6371b6 into pointfreeco:main Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants