-
Notifications
You must be signed in to change notification settings - Fork 555
[HOLD] 🌱 cleanup/registry #3323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
perdasilva
wants to merge
4
commits into
operator-framework:master
Choose a base branch
from
perdasilva:cleanup/registry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17da4ed
to
fbc4418
Compare
45be2e7
to
7df68ff
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
7df68ff
to
2ecbf6c
Compare
Let's hold off on merging until we have the downstream sorted - or at least until Monday |
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
2ecbf6c
to
7aede27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
NOTE: we'll need to update the downstream to push the internal ocp registry and make sure the e2e binary is configured to use it.
Motivation for the change:
Catalog Source images cannot be kind loaded because the Pod is set to Always pull
We wanted to avoid using, e.g. quay. Though, the bundle images are still stored there. And there are still some specific catalog images being used that have been built long ago and live permanently on quay. If we want to target that, that will be a longer story.
Architectural changes:
Before: we stood up a stock kind cluster
Now: We stand-up a local registry side-by-side with kind (largely following their documentation: https://kind.sigs.k8s.io/docs/user/local-registry/).
Related to #3315
Testing remarks:
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue