Skip to content

✨ (hack) Make service-account optional #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented May 7, 2025

Description

  • makes the olmv1 service account admin
  • makes the .spec.serviceAccount optional
  • sets create namespace to true in the helm applier
cat <<EOF | kubectl create -f -
apiVersion: olm.operatorframework.io/v1
kind: ClusterExtension
metadata:
  name: zookeeper-operator
spec:
  namespace: zookeeper-operator
  source:
    sourceType: Catalog
    catalog:
      packageName: zookeeper-operator
      version: 0.17.0
kubectl wait clusterextension zookeeper-operator --for=condition=Installed=true

just_works

Demo

asciicast

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Copy link

netlify bot commented May 7, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit f594f63
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/681c7c95a13e03000824c8b2
😎 Deploy Preview https://deploy-preview-1956--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2025
Copy link

openshift-ci bot commented May 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tmshort for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva perdasilva changed the title :sparkling: (hack) Make service-account optional ✨ : (hack) Make service-account optional May 7, 2025
@perdasilva perdasilva changed the title ✨ : (hack) Make service-account optional ✨ (hack) Make service-account optional May 7, 2025
@perdasilva perdasilva force-pushed the optional-sa branch 3 times, most recently from d57ed80 to 0453eab Compare May 8, 2025 09:42
Signed-off-by: Per Goncalves da Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant