Skip to content

🐛 Fix log initialization #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Apr 14, 2025

Use proper flags and remove use of logrus and klog

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner April 14, 2025 18:24
Copy link

netlify bot commented Apr 14, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 20bb3ff
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67fd65adc5379b00083bc385
😎 Deploy Preview https://deploy-preview-1917--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmshort tmshort changed the title Fix log initialization 🐛 Fix log initialization Apr 14, 2025
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.53%. Comparing base (c54b571) to head (20bb3ff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/catalogd/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1917      +/-   ##
==========================================
+ Coverage   69.51%   69.53%   +0.01%     
==========================================
  Files          68       68              
  Lines        5357     5350       -7     
==========================================
- Hits         3724     3720       -4     
+ Misses       1401     1398       -3     
  Partials      232      232              
Flag Coverage Δ
e2e 50.56% <100.00%> (-0.05%) ⬇️
unit 57.53% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

joelanford
joelanford previously approved these changes Apr 14, 2025
camilamacedo86
camilamacedo86 previously approved these changes Apr 14, 2025
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
Use proper flags and remove use of logrus and klog

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort dismissed stale reviews from camilamacedo86 and joelanford via 20bb3ff April 14, 2025 19:44
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
Copy link

openshift-ci bot commented Apr 14, 2025

New changes are detected. LGTM label has been removed.

@tmshort tmshort added this pull request to the merge queue Apr 14, 2025
Merged via the queue into operator-framework:main with commit 51929d2 Apr 14, 2025
20 of 21 checks passed
@tmshort tmshort deleted the fix-logs branch April 14, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants