Core-940: Add Assignable ISBN, remove iBooks link stuff #2737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
core-940-assignable-isbn-field
branch
from
a25bec3 to
1e0a160
Compare
RoyEJohnson
changed the title
RoyEJohnson
commented
May 28, 2025
| @@ -0,0 +1,9 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
This is a utility function to make tests that use MemoryRouter less noisy
RoyEJohnson
commented
May 28, 2025
| @@ -48,5 +48,17 @@ describe('flex landing footer', () => { | |||
| window.postMessage('CONTACT_FORM_SUBMITTED', '*'); | |||
| await waitFor(() => expect(getIframe()).toBeNull()); | |||
| }); | |||
| it('handles undefined contactFormParams', async () => { | |||
There was a problem hiding this comment.
Unrelated to this PR, but coverage was lacking
RoyEJohnson
changed the title
mwvolo
approved these changes
May 29, 2025
RoyEJohnson
force-pushed
the
core-940-assignable-isbn-field
branch
from
1e0a160 to
9cbe86d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-940