add book list component for flexpages #2736
Conversation
| @@ -0,0 +1,4 @@ | |||
|
|
|||
| .page.flex-page { | |||
| overflow: visible; | |||
There was a problem hiding this comment.
the overflow:hidden on the page was hiding the dropdown menu if there was no following content
| @@ -23,7 +23,7 @@ | |||
| > *:first-child { | |||
| margin-top: 0; | |||
| } | |||
| > *:last-child { | |||
| > *:not(h1, h2, h3, h4, h5, h6):last-child { | |||
There was a problem hiding this comment.
not certain this is the best way to handle this, but without the margin the text descenders are cut off
There was a problem hiding this comment.
This appears to be a line-height issue in the pattern library. hero-h1 line-height is 5rem. It should be normal rather than being specified. This dates back to ancient times when the pattern-library was first spec'd.
| @@ -23,7 +23,7 @@ | |||
| > *:first-child { | |||
| margin-top: 0; | |||
| } | |||
| > *:last-child { | |||
| > *:not(h1, h2, h3, h4, h5, h6):last-child { | |||
There was a problem hiding this comment.
This appears to be a line-height issue in the pattern library. hero-h1 line-height is 5rem. It should be normal rather than being specified. This dates back to ancient times when the pattern-library was first spec'd.
https://openstax.atlassian.net/browse/CORE-900
two slight modifications to the data format required in openstax/openstax-cms#1628