-
Notifications
You must be signed in to change notification settings - Fork 6
add book list component for flexpages #2736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,4 @@ | |||
|
|||
.page.flex-page { | |||
overflow: visible; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the overflow:hidden on the page was hiding the dropdown menu if there was no following content
@@ -23,7 +23,7 @@ | |||
> *:first-child { | |||
margin-top: 0; | |||
} | |||
> *:last-child { | |||
> *:not(h1, h2, h3, h4, h5, h6):last-child { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not certain this is the best way to handle this, but without the margin the text descenders are cut off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a line-height
issue in the pattern library. hero-h1 line-height is 5rem
. It should be normal
rather than being specified. This dates back to ancient times when the pattern-library was first spec'd.
@@ -23,7 +23,7 @@ | |||
> *:first-child { | |||
margin-top: 0; | |||
} | |||
> *:last-child { | |||
> *:not(h1, h2, h3, h4, h5, h6):last-child { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a line-height
issue in the pattern library. hero-h1 line-height is 5rem
. It should be normal
rather than being specified. This dates back to ancient times when the pattern-library was first spec'd.
https://openstax.atlassian.net/browse/CORE-900
two slight modifications to the data format required in openstax/openstax-cms#1628