-
Notifications
You must be signed in to change notification settings - Fork 6
Port components to ts 5 #2724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Port components to ts 5 #2724
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
26d40c3
Paginator & tests
RoyEJohnson ae42ca8
progress-ring
RoyEJohnson d09364f
quote component simplified and moved to body-units
RoyEJohnson b2b2d50
Radio panel
RoyEJohnson 0eac4c8
role-selector
RoyEJohnson 438bdbc
salesforce-form, plus finally fixed the tilde issue
RoyEJohnson 6237cb8
select
RoyEJohnson d7fdec0
share icons (always minimal)
RoyEJohnson 77d566c
Prettier
RoyEJohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import React from 'react'; | ||
import RawHTML from '~/components/jsx-helpers/raw-html'; | ||
|
||
export default function Quote({ | ||
model | ||
}: { | ||
model: { | ||
content: string; | ||
attribution: string; | ||
}; | ||
}) { | ||
return ( | ||
<div className="quote"> | ||
<blockquote> | ||
<RawHTML html={model.content} /> | ||
{Boolean(model.attribution) && ( | ||
<div className="attribution">— {model.attribution}</div> | ||
)} | ||
</blockquote> | ||
</div> | ||
); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import {useState, useCallback} from 'react'; | ||
import buildContext from '~/components/jsx-helpers/build-context'; | ||
|
||
type ContextParams = { | ||
resultsPerPage?: number; | ||
initialPage?: number; | ||
}; | ||
|
||
function useContextValue(params: ContextParams = {}) { | ||
const {resultsPerPage = 1, initialPage = 1} = params; | ||
const [currentPage, setCurrentPage] = useState(initialPage); | ||
const firstOnPage = (currentPage - 1) * resultsPerPage; | ||
const lastOnPage = firstOnPage + resultsPerPage - 1; | ||
const isVisible = useCallback( | ||
(childIndex: number) => | ||
childIndex >= firstOnPage && childIndex <= lastOnPage, | ||
[firstOnPage, lastOnPage] | ||
); | ||
const visibleChildren = useCallback( | ||
(children: React.ReactNode[]) => | ||
children.slice(firstOnPage, lastOnPage + 1), | ||
[firstOnPage, lastOnPage] | ||
); | ||
|
||
return { | ||
currentPage, | ||
setCurrentPage, | ||
resultsPerPage, | ||
firstOnPage, | ||
lastOnPage, | ||
isVisible, | ||
visibleChildren | ||
}; | ||
} | ||
|
||
const {useContext, ContextProvider} = buildContext({useContextValue}); | ||
|
||
export {useContext as default, ContextProvider as PaginatorContextProvider}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was moved from being its own component to being part of body-units, since nothing else used it. Also simplified it a bit, since there was an image feature that wasn't being used, and with that gone, the
quote-bucket
wrapper wasn't needed.