Port components to ts 4 #2723
Merged
Port components to ts 4 #2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
commented
Apr 1, 2025
| () => new Intl.DisplayNames([language], {type: 'language'}), | ||
| [language] | ||
| const text = React.useMemo( | ||
| () => (new Intl.DisplayNames([language], {type: 'language'})).of(locale), |
There was a problem hiding this comment.
We don't support browsers so old that Intl.DisplayNames isn't supported, so I took the fallback out.
jivey
reviewed
Apr 22, 2025
RoyEJohnson
force-pushed
the
port-components-to-ts-4
branch
from
a8d3c58 to
9d295f0
Compare
RoyEJohnson
force-pushed
the
port-components-to-ts-4
branch
2 times, most recently
from
f073d46 to
a2054a7
Compare
jivey
approved these changes
May 13, 2025
RoyEJohnson
force-pushed
the
port-components-to-ts-4
branch
from
a2054a7 to
542594f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-857