Add app configurations for all apps #1624
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings enhancements to the app structure that comply with Django 3+. Introduced `apps.py` files with Django AppConfig classes for all apps in the project. Updated `__init__.py` files to include `default_app_config` for each app. Enhanced WSGI configuration to use WhiteNoise for static file handling.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds Django AppConfig configuration files and related settings updates to enhance application structure and support for Django 3+.
- Introduces app-specific configuration in new apps.py files for apps like news, mail, global_settings, errata, donations, books, api, and accounts.
- Updates settings modules for REST framework and OpenStax Accounts integration, along with adjustments to the WSGI configuration to support WhiteNoise.
- Adjusts project-level settings to import these modular configuration components.
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| openstax/settings/components/api.py | Added REST framework settings configuration |
| openstax/settings/components/accounts.py | Added Accounts-related settings with dynamic URL construction |
| openstax/settings/components/init.py | Aggregated and exposed individual settings components |
| openstax/settings/init.py | Updated environment-based settings loading |
| news/apps.py & news/init.py | Introduced app config for news with default_app_config |
| mail/apps.py & mail/init.py | Introduced app config for mail with default_app_config |
| global_settings/apps.py & global_settings/init.py | Updated global settings app configuration and default_app_config |
| errata/apps.py & errata/init.py | Added app configuration for errata |
| donations/apps.py & donations/init.py | Added app configuration for donations |
| books/apps.py & books/init.py | Added app configuration for books |
| api/apps.py & api/init.py | Introduced app config for api with default_app_config |
| accounts/apps.py & accounts/init.py | Introduced app config for accounts with default_app_config |
Comment on lines
+19
to
+20
| """ | ||
| # Import signal handlers if they exist |
There was a problem hiding this comment.
[nitpick] If the commented-out signal import is not needed, consider removing it to reduce clutter, or add a note explaining its anticipated future use.
Suggested change
| """ | |
| # Import signal handlers if they exist | |
| If signal handlers are added in the future, uncomment the line below to import them. | |
| """ |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
Merged
TomWoodward
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings enhancements to the app structure that comply with Django 3+.
Introduced
apps.pyfiles with Django AppConfig classes for all apps in the project. Updated__init__.pyfiles to includedefault_app_configfor each app. Enhanced WSGI configuration to use WhiteNoise for static file handling.