Core 845 postbake rex link #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a formatted anchor that will be updated in postbake
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #406 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 216 216
Lines 3570 3547 -23
=========================================
- Hits 3570 3547 -23
🚀 New features to boost your workflow:
|
jivey
reviewed
Mar 31, 2025
| @@ -25,7 +20,7 @@ def bake(book:) | |||
|
|
|||
| iframe.prepend(child: | |||
| <<~HTML | |||
| <a class="os-is-link" href="#{iframe_link}" target="_blank" rel="noopener nofollow">#{I18n.t(:iframe_link_text)}</a> | |||
| <a class="os-is-link" data-needs-rex-link="true" href="#{iframe_link}" target="_blank" rel="noopener nofollow">#{I18n.t(:iframe_link_text)}</a> | |||
There was a problem hiding this comment.
So postbake uses this data attribute to do something? I tried looking it up but didn't find anything (maybe it's not found with the full attribute name?)
There was a problem hiding this comment.
@jivey those changes can be found in the other PR: openstax/enki#405.
There was a problem hiding this comment.
Ah thanks I did not notice the second link
jivey
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-845
Depends on openstax/enki#405
Mark anchors as needing rex links instead of trying to create the links here. The links are generated much more easily and more accurately in postbake since that step also generates the book/page slugs.