Skip to content

CORE-986: Fix color contrast of signup heading #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented May 15, 2025

CORE-986
New color contrast ratio is 5.
Also moved the disabled-submit styling to CSS
Also added some JS to control the disabled state of the Continue button on login.

@RoyEJohnson RoyEJohnson force-pushed the core-986-fix-color-contrast-of-signup-heading branch from 8aa26a9 to a15f0c6 Compare May 15, 2025 17:17
@RoyEJohnson RoyEJohnson requested a review from mwvolo May 15, 2025 19:41
[CORE-986]
New color contrast ratio is 5.
Also moved the disabled-submit styling to CSS
Also added some JS to control the disabled state of the Continue button on login.
@RoyEJohnson RoyEJohnson force-pushed the core-986-fix-color-contrast-of-signup-heading branch from a15f0c6 to f08cd67 Compare May 29, 2025 20:18
Copy link

github-actions bot commented Jun 5, 2025

❌ Tests failed for Ruby 3.1.

Test Results Report

Summary

  • Ruby Version: 3.1
  • PostgreSQL Version: 16
  • Status: failure

Failures (16)

  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=1) FAILED (0 prior attempts) with OpenURI::HTTPError: 404 Not Found
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=2) FAILED (0 prior attempts) with OpenURI::HTTPError:
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=3) FAILED (0 prior attempts) with OpenURI::HTTPError: 504 Gateway Timeout
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=4) FAILED (0 prior attempts) with RuntimeError: Some Error
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=5) FAILED (0 prior attempts) with OAuth2::Error:
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=6) FAILED (0 prior attempts) with OAuth2::Error:
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=7) FAILED (0 prior attempts) with OAuth2::Error:
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=8) FAILED (0 prior attempts) with ActiveRecord::RecordInvalid: Validation failed:
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=9) FAILED (0 prior attempts) with NoMethodError: NoMethodError
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=10) FAILED (0 prior attempts) with NotYetImplemented: NotYetImplemented
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=11) FAILED (0 prior attempts) with NameError: NameError
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=12) FAILED (0 prior attempts) with ActiveRecord::RecordNotFound: ActiveRecord::RecordNotFound
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=13) FAILED (0 prior attempts) with NoMethodError: undefined method `message' for nil:NilClass
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=14) FAILED (0 prior attempts) with JSON::ParserError: JSON::ParserError
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=15) FAILED (0 prior attempts) with ArgumentError: ArgumentError
  • 2025-06-05T15:15:13+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2706)] Job ActiveJob::Base (id=16) FAILED (0 prior attempts) with Addressable::URI::InvalidURIError: Addressable::URI::InvalidURIError

Test Log Excerpt

  �[1m�[36mAuthentication Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "authentications" WHERE "authentications"."uid" = $1 AND "authentications"."provider" = $2 LIMIT $3�[0m  [["uid", "8"], ["provider", "identity"], ["LIMIT", 1]]
  �[1m�[36mAuthentication Create (0.3ms)�[0m  �[1m�[32mINSERT INTO "authentications" ("user_id", "provider", "uid", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5) RETURNING "id"�[0m  [["user_id", 18], ["provider", "identity"], ["uid", "8"], ["created_at", "2025-06-05 15:15:50.474535"], ["updated_at", "2025-06-05 15:15:50.474535"]]
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mRELEASE SAVEPOINT active_record_2�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mSAVEPOINT active_record_2�[0m
  �[1m�[36mApplicationUser Update All (0.3ms)�[0m  �[1m�[33mUPDATE "application_users" SET unread_updates = unread_updates + 1 WHERE "application_users"."user_id" = $1�[0m  [["user_id", 18]]
  �[1m�[36mUser Update (0.3ms)�[0m  �[1m�[33mUPDATE "users" SET "updated_at" = $1, "state" = $2 WHERE "users"."id" = $3�[0m  [["updated_at", "2025-06-05 15:15:50.476724"], ["state", "needs_profile"], ["id", 18]]
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mRELEASE SAVEPOINT active_record_2�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[31mROLLBACK TO SAVEPOINT active_record_1�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mSAVEPOINT active_record_1�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mSAVEPOINT active_record_2�[0m
  �[1m�[36mFinePrint::Contract Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "fine_print_contracts" WHERE "fine_print_contracts"."version" = $1 AND "fine_print_contracts"."name" = $2 LIMIT $3�[0m  [["version", 1], ["name", "general_terms_of_use"], ["LIMIT", 1]]
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[31mROLLBACK TO SAVEPOINT active_record_2�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mSAVEPOINT active_record_2�[0m
  �[1m�[36mFinePrint::Contract Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "fine_print_contracts" WHERE "fine_print_contracts"."version" = $1 AND "fine_print_contracts"."name" = $2 LIMIT $3�[0m  [["version", 1], ["name", "privacy_policy"], ["LIMIT", 1]]
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[31mROLLBACK TO SAVEPOINT active_record_2�[0m
  �[1m�[36mFinePrint::Contract Load (0.3ms)�[0m  �[1m�[34mSELECT "fine_print_contracts".* FROM "fine_print_contracts" ORDER BY "fine_print_contracts"."name" ASC, "fine_print_contracts"."version" DESC�[0m
  �[1m�[36mUser Load (0.3ms)�[0m  �[1m�[34mSELECT "users".* FROM "users" WHERE "users"."username" = $1 LIMIT $2�[0m  [["username", "user"], ["LIMIT", 1]]
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mSAVEPOINT active_record_2�[0m
  �[1m�[36mUser Exists? (0.4ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "users" WHERE LOWER("users"."username") = LOWER($1) LIMIT $2�[0m  [["username", "user"], ["LIMIT", 1]]
  �[1m�[36mUser Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "users" WHERE "users"."uuid" = $1 LIMIT $2�[0m  [["uuid", "c7f9704b-eb17-4e9f-97b2-c233aea5a8b6"], ["LIMIT", 1]]
  �[1m�[36mApplicationUser Update All (0.3ms)�[0m  �[1m�[33mUPDATE "application_users" SET unread_updates = unread_updates + 1 WHERE "application_users"."user_id" IS NULL AND (1=0)�[0m
  �[1m�[36mUser Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "users" WHERE LOWER("users"."username") = LOWER($1) LIMIT $2�[0m  [["username", "user"], ["LIMIT", 1]]
  �[1m�[36mUser Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "users" WHERE "users"."uuid" = $1 LIMIT $2�[0m  [["uuid", "c7f9704b-eb17-4e9f-97b2-c233aea5a8b6"], ["LIMIT", 1]]
  �[1m�[36mSchool Create (0.3ms)�[0m  �[1m�[32mINSERT INTO "schools" ("salesforce_id", "name", "city", "state", "type", "location", "sheerid_school_name", "is_kip", "is_child_of_kip", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11) RETURNING "id"�[0m  [["salesforce_id", "0010v06NMZHmIwi"], ["name", "Keebler Group"], ["city", "Port Patfort"], ["state", "South Carolina"], ["type", "High School"], ["location", "Domestic"], ["sheerid_school_name", "Keebler Group (Port Patfort, South Carolina)"], ["is_kip", true], ["is_child_of_kip", false], ["created_at", "2025-06-05 15:15:50.496640"], ["updated_at", "2025-06-05 15:15:50.496640"]]
  �[1m�[36mUser Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "users" WHERE LOWER("users"."username") = LOWER($1) LIMIT $2�[0m  [["username", "user"], ["LIMIT", 1]]
  �[1m�[36mUser Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "users" WHERE "users"."uuid" = $1 LIMIT $2�[0m  [["uuid", "c7f9704b-eb17-4e9f-97b2-c233aea5a8b6"], ["LIMIT", 1]]
  �[1m�[36mApplicationUser Update All (0.3ms)�[0m  �[1m�[33mUPDATE "application_users" SET unread_updates = unread_updates + 1 WHERE "application_users"."user_id" IS NULL AND (1=0)�[0m
  �[1m�[36mUser Create (0.4ms)�[0m  �[1m�[32mINSERT INTO "users" ("username", "created_at", "updated_at", "first_name", "last_name", "uuid", "state", "role", "is_profile_complete", "school_id", "consent_preferences") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11) RETURNING "id"�[0m  [["username", "user"], ["created_at", "2025-06-05 15:15:50.500650"], ["updated_at", "2025-06-05 15:15:50.500650"], ["first_name", "Monty"], ["last_name", "Hermiston"], ["uuid", "c7f9704b-eb17-4e9f-97b2-c233aea5a8b6"], ["state", "activated"], ["role", 1], ["is_profile_complete", true], ["school_id", 17], ["consent_preferences", "\"{\\\"accepted\\\":[\\\"necessary\\\",\\\"analytics\\\",\\\"functional\\\"],\\\"rejected\\\":[\\\"advertisement\\\",\\\"performance\\\"]}\""]]
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mRELEASE SAVEPOINT active_record_2�[0m
  �[1m�[36mFinePrint::Contract Load (0.3ms)�[0m  �[1m�[34mSELECT "fine_print_contracts".* FROM "fine_print_contracts" ORDER BY "fine_print_contracts"."name" ASC, "fine_print_contracts"."version" DESC�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mSAVEPOINT active_record_2�[0m
  �[1m�[36mFinePrint::Signature Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "fine_print_signatures" WHERE "fine_print_signatures"."contract_id" = $1 AND "fine_print_signatures"."user_type" = $2 AND "fine_print_signatures"."user_id" = $3 LIMIT $4�[0m  [["contract_id", 1], ["user_type", "User"], ["user_id", 19], ["LIMIT", 1]]
  �[1m�[36mFinePrint::Signature Create (0.3ms)�[0m  �[1m�[32mINSERT INTO "fine_print_signatures" ("contract_id", "user_type", "user_id", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5) RETURNING "id"�[0m  [["contract_id", 1], ["user_type", "User"], ["user_id", 19], ["created_at", "2025-06-05 15:15:50.505231"], ["updated_at", "2025-06-05 15:15:50.505231"]]
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mRELEASE SAVEPOINT active_record_2�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mSAVEPOINT active_record_2�[0m
  �[1m�[36mFinePrint::Signature Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "fine_print_signatures" WHERE "fine_print_signatures"."contract_id" = $1 AND "fine_print_signatures"."user_type" = $2 AND "fine_print_signatures"."user_id" = $3 LIMIT $4�[0m  [["contract_id", 2], ["user_type", "User"], ["user_id", 19], ["LIMIT", 1]]
  �[1m�[36mFinePrint::Signature Create (0.3ms)�[0m  �[1m�[32mINSERT INTO "fine_print_signatures" ("contract_id", "user_type", "user_id", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5) RETURNING "id"�[0m  [["contract_id", 2], ["user_type", "User"], ["user_id", 19], ["created_at", "2025-06-05 15:15:50.507939"], ["updated_at", "2025-06-05 15:15:50.507939"]]
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mRELEASE SAVEPOINT active_record_2�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mSAVEPOINT active_record_2�[0m
  �[1m�[36mIdentity Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "identities" WHERE "identities"."user_id" = $1 LIMIT $2�[0m  [["user_id", 19], ["LIMIT", 1]]
  �[1m�[36mIdentity Create (0.3ms)�[0m  �[1m�[32mINSERT INTO "identities" ("password_digest", "created_at", "updated_at", "user_id") VALUES ($1, $2, $3, $4) RETURNING "id"�[0m  [["password_digest", "$2a$04$w.JnJo9aaxnai9B0jm9qxuf28StIX0Vj5Cbh7gThY3pHtuE3iUYVy"], ["created_at", "2025-06-05 15:15:50.511558"], ["updated_at", "2025-06-05 15:15:50.511558"], ["user_id", 19]]
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mRELEASE SAVEPOINT active_record_2�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mSAVEPOINT active_record_2�[0m
  �[1m�[36mAuthentication Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "authentications" WHERE "authentications"."provider" = $1 AND "authentications"."user_id" = $2 LIMIT $3�[0m  [["provider", "identity"], ["user_id", 19], ["LIMIT", 1]]
  �[1m�[36mAuthentication Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "authentications" WHERE "authentications"."uid" = $1 AND "authentications"."provider" = $2 LIMIT $3�[0m  [["uid", "9"], ["provider", "identity"], ["LIMIT", 1]]
  �[1m�[36mAuthentication Create (0.3ms)�[0m  �[1m�[32mINSERT INTO "authentications" ("user_id", "provider", "uid", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5) RETURNING "id"�[0m  [["user_id", 19], ["provider", "identity"], ["uid", "9"], ["created_at", "2025-06-05 15:15:50.514692"], ["updated_at", "2025-06-05 15:15:50.514692"]]
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mRELEASE SAVEPOINT active_record_2�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[31mROLLBACK TO SAVEPOINT active_record_1�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[31mROLLBACK�[0m

Check the workflow run for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants