Skip to content

Replace hashmap with linked hashmap to fix schema order #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xinyual
Copy link
Contributor

@xinyual xinyual commented Jun 5, 2025

Description

This PR use linked hashmap to fix the schema order so the future IT won't be influenced by external variables like random seeds.

It influences several ITs. The fix is mainly divided into:

  1. Add fields, for most IT, since we don't care about the schema order, like eventstats, we add a field so the current IT could pass
  2. change expectation, especially for explain. Since the order is changed and logical plan is changed correspondingly, we change expectations.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
#3739

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

xinyual added 3 commits June 5, 2025 15:03
Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant