[BUG FIX] Enable Correct Sorting for Metrics in Query Insights Dashboard #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
KishoreKicha14
requested review from
ansjcy,
jainankitk,
deshsidd and
dzane17
as code owners
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
…ard (#173) * Bug fix Sort and added cypress for them Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * Updated Snapshots Signed-off-by: Kishore Kumaar Natarajan <[email protected]> --------- Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]> (cherry picked from commit 3843f4f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights-dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/query-insights-dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-173-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3843f4fd512c9d83962cf70e9b775b861f87dfd2
# Push it to GitHub
git push --set-upstream origin backport/backport-173-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights-dashboards/backport-2.xThen, create a pull request where the |
ansjcy
pushed a commit
that referenced
this pull request
Apr 24, 2025
…ard (#173) (#174) * Bug fix Sort and added cypress for them * Updated Snapshots --------- (cherry picked from commit 3843f4f) Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
KishoreKicha14
added a commit
to KishoreKicha14/query-insights-dashboards
that referenced
this pull request
May 1, 2025
…ard (opensearch-project#173) * Bug fix Sort and added cypress for them Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * Updated Snapshots Signed-off-by: Kishore Kumaar Natarajan <[email protected]> --------- Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
dzane17
pushed a commit
to dzane17/query-insights-dashboards
that referenced
this pull request
May 27, 2025
…ard (opensearch-project#173) * Bug fix Sort and added cypress for them Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * Updated Snapshots Signed-off-by: Kishore Kumaar Natarajan <[email protected]> --------- Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
dzane17
pushed a commit
to dzane17/query-insights-dashboards
that referenced
this pull request
May 27, 2025
…ard (opensearch-project#173) Signed-off-by: David Zane <[email protected]>
dzane17
added a commit
that referenced
this pull request
May 28, 2025
…Insights Dashboard + dependent PRs (#200) * Feat: dynamically display columns (#103) Signed-off-by: David Zane <[email protected]> * [Improvement] Improved Cypress test that validates the dynamic column (#168) Signed-off-by: David Zane <[email protected]> * [BUG FIX] Enable Correct Sorting for Metrics in Query Insights Dashboard (#173) Signed-off-by: David Zane <[email protected]> --------- Signed-off-by: David Zane <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 28, 2025
…Insights Dashboard + dependent PRs (#200) * Feat: dynamically display columns (#103) Signed-off-by: David Zane <[email protected]> * [Improvement] Improved Cypress test that validates the dynamic column (#168) Signed-off-by: David Zane <[email protected]> * [BUG FIX] Enable Correct Sorting for Metrics in Query Insights Dashboard (#173) Signed-off-by: David Zane <[email protected]> --------- Signed-off-by: David Zane <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]> (cherry picked from commit 7a21131) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dzane17
pushed a commit
that referenced
this pull request
May 28, 2025
…Insights Dashboard + dependent PRs (#200) (#201) * Feat: dynamically display columns (#103) * [Improvement] Improved Cypress test that validates the dynamic column (#168) * [BUG FIX] Enable Correct Sorting for Metrics in Query Insights Dashboard (#173) (cherry picked from commit 7a21131) Signed-off-by: David Zane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the Query Insights Dashboard where the following metric columns were not sorting correctly due to improper sortable configuration for Latency, CPU time, Memory Usage and Query Count.
Also improved the test coverage to ensure these functionalities work properly.
Issues Resolved
Closes: [#170]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.