[Improvement] Improved Cypress test that validates the dynamic column #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
KishoreKicha14
requested review from
ansjcy,
jainankitk,
deshsidd and
dzane17
as code owners
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
ansjcy
reviewed
Apr 22, 2025
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
|
LGTM! thanks for fixing it! |
ansjcy
approved these changes
Apr 23, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
…#168) * Improve the Dynamic Column Cypress Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * Improve the Dynamic Column Cypress Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * updated timestamp with old date Signed-off-by: Kishore Kumaar Natarajan <[email protected]> --------- Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]> (cherry picked from commit 28fd1f9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy
pushed a commit
that referenced
this pull request
Apr 23, 2025
…#168) (#171) * Improve the Dynamic Column Cypress * Improve the Dynamic Column Cypress * updated timestamp with old date --------- (cherry picked from commit 28fd1f9) Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
dzane17
pushed a commit
to dzane17/query-insights-dashboards
that referenced
this pull request
May 27, 2025
…opensearch-project#168) * Improve the Dynamic Column Cypress Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * Improve the Dynamic Column Cypress Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * updated timestamp with old date Signed-off-by: Kishore Kumaar Natarajan <[email protected]> --------- Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
dzane17
pushed a commit
to dzane17/query-insights-dashboards
that referenced
this pull request
May 27, 2025
…opensearch-project#168) Signed-off-by: David Zane <[email protected]>
dzane17
added a commit
that referenced
this pull request
May 28, 2025
…Insights Dashboard + dependent PRs (#200) * Feat: dynamically display columns (#103) Signed-off-by: David Zane <[email protected]> * [Improvement] Improved Cypress test that validates the dynamic column (#168) Signed-off-by: David Zane <[email protected]> * [BUG FIX] Enable Correct Sorting for Metrics in Query Insights Dashboard (#173) Signed-off-by: David Zane <[email protected]> --------- Signed-off-by: David Zane <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 28, 2025
…Insights Dashboard + dependent PRs (#200) * Feat: dynamically display columns (#103) Signed-off-by: David Zane <[email protected]> * [Improvement] Improved Cypress test that validates the dynamic column (#168) Signed-off-by: David Zane <[email protected]> * [BUG FIX] Enable Correct Sorting for Metrics in Query Insights Dashboard (#173) Signed-off-by: David Zane <[email protected]> --------- Signed-off-by: David Zane <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]> (cherry picked from commit 7a21131) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dzane17
pushed a commit
that referenced
this pull request
May 28, 2025
…Insights Dashboard + dependent PRs (#200) (#201) * Feat: dynamically display columns (#103) * [Improvement] Improved Cypress test that validates the dynamic column (#168) * [BUG FIX] Enable Correct Sorting for Metrics in Query Insights Dashboard (#173) (cherry picked from commit 7a21131) Signed-off-by: David Zane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an automated Cypress test that validates the dynamic column rendering behavior in the Query Insights Dashboard using stubbed top_queries API responses. It ensures that the UI correctly displays expected headers and rows based on intercepted data.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.