Fix auto-instrumentation with multi annotation #3780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Oliveira <[email protected]>
jaronoff97
approved these changes
Mar 6, 2025
tests/e2e-instrumentation/instrumentation-dotnet-multiannotation/00-install-collector.yaml
Outdated
Show resolved
Hide resolved
iblancasa
reviewed
Mar 6, 2025
...s/e2e-instrumentation/instrumentation-dotnet-multiannotation/00-install-instrumentation.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Yuri Oliveira <[email protected]>
Signed-off-by: Yuri Oliveira <[email protected]>
iblancasa
approved these changes
Mar 7, 2025
|
@yuriolisa the e2e tests are failing |
@pavolloffay, I was working on it today after talking with @iblancasa about the best approach to the pod's precedence. You can see through this slack thread. |
Signed-off-by: Yuri Oliveira <[email protected]> Fixed pod's precedence in auto-instrumentation Signed-off-by: Yuri Oliveira <[email protected]> Fixed pod's precedence in auto-instrumentation Signed-off-by: Yuri Oliveira <[email protected]> Fixed pod's precedence in auto-instrumentation Signed-off-by: Yuri Oliveira <[email protected]> Fixed pod's precedence in auto-instrumentation Signed-off-by: Yuri Oliveira <[email protected]> Fixed pod's precedence in auto-instrumentation Signed-off-by: Yuri Oliveira <[email protected]>
yuriolisa
force-pushed
the
fix-auto-instrumentation-annotations
branch
from
56b1710 to
1d4112d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It fix a case when the auto instrumentation fails with annotations set on both namespace and pod with different valid values.
Link to tracking Issue(s):
Testing:
Documentation: