-
Notifications
You must be signed in to change notification settings - Fork 724
Add samples for SYCL-Graph extension #2643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Add samples for SYCL-Graph extension #2643
Conversation
pinging @jimmytwei for visibility |
cd2a455
to
b7e6b94
Compare
b7e6b94
to
d8cf20c
Compare
Note that 5 out of 7 samples in here use the |
a320036
to
ebf31dc
Compare
…h aspect. Also changed README.
ebf31dc
to
55560f5
Compare
DirectProgramming/C++SYCL/SYCL-Graph/dot-product/src/dotProduct.cpp
Outdated
Show resolved
Hide resolved
DirectProgramming/C++SYCL/SYCL-Graph/dot-product/src/dotProduct.cpp
Outdated
Show resolved
Hide resolved
DirectProgramming/C++SYCL/SYCL-Graph/diamond-dependency/README.md
Outdated
Show resolved
Hide resolved
First round of comments ... Do we also want to add a graphified version of an existing example like: |
Co-authored-by: Pablo Reble <[email protected]>
Co-authored-by: Pablo Reble <[email protected]>
Co-authored-by: Pablo Reble <[email protected]>
Co-authored-by: Pablo Reble <[email protected]>
More samples is a good idea IMO. But given the current scope of this work, I think it'd be more manageable to add it in a follow-up PR. |
@konradkusiak97 My suggestion is to add in those samples later. The samples in this repo need to compile and run with the latest oneAPI toolkits and drivers. We don't want to submit something that won't work in the current or the next release. |
@konradkusiak97 Both samples compile and run successfully but with no output. It'll be great to output some sort of message to indicate that the sample ran successfully or failed. |
a251d1f
to
f2830c5
Compare
f2830c5
to
0ad5c2a
Compare
I added code verifying the results and it prints a message on successful execution. |
Adding a New Sample(s)
Description
This PR adds code examples demonstrating the use case of sycl_ext_oneapi_graph extension.
Checklist
Administrative
Code Development
Security and Legal
Review