Skip to content

Add samples for SYCL-Graph extension #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

konradkusiak97
Copy link

@konradkusiak97 konradkusiak97 commented Apr 2, 2025

Adding a New Sample(s)

Description

This PR adds code examples demonstrating the use case of sycl_ext_oneapi_graph extension.

Checklist

Administrative

  • Review sample design with the appropriate Domain Expert:
  • If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager

Code Development

Security and Legal

  • OSPDT Approval (see Project Manager for assistance)
  • Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
  • Bandit Scans (Python only)
  • Virus scan

Review

  • Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
  • Review readme with Tom Lenth(@tomlenth) and/or Project Manager
  • Tested using Dev Cloud when applicable

@konradkusiak97
Copy link
Author

pinging @jimmytwei for visibility

@konradkusiak97 konradkusiak97 force-pushed the addSyclGraphSample branch 2 times, most recently from cd2a455 to b7e6b94 Compare April 2, 2025 10:05
@konradkusiak97
Copy link
Author

Note that 5 out of 7 samples in here use the Update feature which for intel GPUs is available only with embargoed drivers and hence not available to the users just yet. It's currently possible to use those examples on AMD and Nvidia backends though. AFAIK this will become available in L0 drivers in the coming months. @jimmytwei, What is your preference in terms of adding those limited working samples now or later, when the feature is available for intel gpus?

@konradkusiak97 konradkusiak97 force-pushed the addSyclGraphSample branch 2 times, most recently from a320036 to ebf31dc Compare April 28, 2025 14:03
@reble
Copy link
Contributor

reble commented May 2, 2025

First round of comments ...

Do we also want to add a graphified version of an existing example like:
https://github.com/reble/oneAPI-samples/blob/sycl-graph/DirectProgramming/DPC%2B%2B/StructuredGrids/1d_HeatTransfer/src/1d_HeatTransfer.cpp

@konradkusiak97
Copy link
Author

First round of comments ...

Do we also want to add a graphified version of an existing example like: https://github.com/reble/oneAPI-samples/blob/sycl-graph/DirectProgramming/DPC%2B%2B/StructuredGrids/1d_HeatTransfer/src/1d_HeatTransfer.cpp

More samples is a good idea IMO. But given the current scope of this work, I think it'd be more manageable to add it in a follow-up PR.

@jimmytwei
Copy link
Contributor

Note that 5 out of 7 samples in here use the Update feature which for intel GPUs is available only with embargoed drivers and hence not available to the users just yet. It's currently possible to use those examples on AMD and Nvidia backends though. AFAIK this will become available in L0 drivers in the coming months. @jimmytwei, What is your preference in terms of adding those limited working samples now or later, when the feature is available for intel gpus?

@konradkusiak97 My suggestion is to add in those samples later. The samples in this repo need to compile and run with the latest oneAPI toolkits and drivers. We don't want to submit something that won't work in the current or the next release.

@jimmytwei
Copy link
Contributor

@konradkusiak97 Both samples compile and run successfully but with no output. It'll be great to output some sort of message to indicate that the sample ran successfully or failed.

@konradkusiak97
Copy link
Author

konradkusiak97 commented May 7, 2025

@konradkusiak97 Both samples compile and run successfully but with no output. It'll be great to output some sort of message to indicate that the sample ran successfully or failed.

I added code verifying the results and it prints a message on successful execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants