Better compatibility with FUMBBL #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modification of some convetions to ensure a better compatibility with FUMBBL
sync upstream repo
|
I am afraid it will break the UI because there are no changes to the web module. Have you checked if it works when playing in the web app? Also, do you have any updates on the replay module? I am very curious. |
|
Hi Niels,
It’s true, I have to test the web module.
My replay module is done but I have to test more games before submitting it. I will ask on Discord a list of match Orc vs Humans. I think I will need to add some code for the Ogre player.
I have also pushed another branch with some rule corrections (mainly tackle, interception and apothecary)
Rémy
Envoyé de mon iPhone
… Le 22 avr. 2019 à 12:49, Niels Justesen ***@***.***> a écrit :
I am afraid it will break the UI because there are no changes to the web module. Have you checked if it works when playing in the web app? Also, do you have any updates on the replay module? I am very curious.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Any news on this? I would love to try the replay module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to replay fumbbl games with ffai, I made the following modifications:
Before: After:
123 812
4X5 7X3
678 654