Skip to content

NimbleSpinner import missing from Mapping column doc #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

NimbleSpinner import missing from Mapping column doc #2621

merged 1 commit into from
May 30, 2025

Conversation

fredvisser
Copy link
Contributor

Pull Request

🤨 Rationale

With the creating of the nimble-react package, one import was missed

👩‍💻 Implementation

Import the missing NimbleSpinner component into the MDX doc.

🧪 Testing

  • Confirmed the import resolves the broken doc page
  • Opened all doc pages to confirm no other imports were missed

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

rajsite
rajsite approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and also pretty concerning that it didn't cause a build failure

@rajsite rajsite merged commit e5a1e1a into main May 30, 2025
13 checks passed
@rajsite rajsite deleted the users/fvisser/missing-spinner-import branch May 30, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

@jattasNI jattasNI Awaiting requested review from jattasNI jattasNI is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredvisser @rajsite