Skip to content

ARM Megatests #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d3f48aa
ci: Add containers_config workflow
edmundmiller Mar 17, 2025
ee28ef2
ci: Give it a matrix
edmundmiller Mar 17, 2025
09a8ce8
ci: Update names
edmundmiller Mar 17, 2025
d082b44
ci: Add commit step
edmundmiller Mar 17, 2025
f44a3b4
ci: Check out with bot auth token and just add containers
edmundmiller Mar 17, 2025
f45a4a4
ci: Checkout pull request HEAD commit instead of merge commit
edmundmiller Mar 17, 2025
36980a3
ci: Try with head_ref
edmundmiller Mar 17, 2025
3a6b4ca
ci: Add a .
edmundmiller Mar 17, 2025
095a515
ci: Run containers snapshot in one step
edmundmiller Mar 17, 2025
4fb7547
ci: Sort the outputs ourselves
edmundmiller Mar 17, 2025
05fe8db
[automated] Update container configs
nf-core-bot Mar 17, 2025
d54bcf9
build: Try locking down some containers
edmundmiller Mar 17, 2025
dd3b67c
[automated] Update container configs
nf-core-bot Mar 17, 2025
f88b314
build: Rename arm profile to apple and make a real arm profile
edmundmiller Mar 25, 2025
c58a256
ci: Add ARM Megatests
edmundmiller Mar 26, 2025
b2a5b08
chore: upload-artifact@v3 is deprecated
edmundmiller Mar 26, 2025
738ddaa
ci: Update artifact name format in cloud tests workflow
edmundmiller Apr 11, 2025
201f657
build: Rename to graviton for now
edmundmiller Apr 11, 2025
9bb03b0
[automated] Update container configs
nf-core-bot Apr 11, 2025
dc75a5e
chore(arm): Bump modules
edmundmiller Apr 22, 2025
91c65a2
build(arm): Update profile names
edmundmiller Apr 22, 2025
be0cfc4
refactor: Bring arm back, and just use arm on macos
edmundmiller May 9, 2025
c32fd2b
chore: nf-core modules --branch arm-runners update
edmundmiller May 9, 2025
512f642
chore: Manually bump star version
edmundmiller May 9, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/cloud_tests_full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,23 +22,24 @@ jobs:
strategy:
matrix:
aligner: ["star_salmon", "star_rsem"]
arch: ["arm64", "x86_64"]
steps:
- uses: seqeralabs/action-tower-launch@v2
with:
workspace_id: ${{ secrets.TOWER_WORKSPACE_ID }}
access_token: ${{ secrets.TOWER_ACCESS_TOKEN }}
compute_env: ${{ secrets.TOWER_CE_AWS_CPU }}
compute_env: ${{ matrix.arch == 'arm64' && secrets.TOWER_CE_AWS_CPU_ARM64 || secrets.TOWER_CE_AWS_CPU }}
workdir: "${{ secrets.TOWER_BUCKET_AWS }}/work/rnaseq/work-${{ github.sha }}"
run_name: "aws_rnaseq_full_${{ matrix.aligner }}"
run_name: "aws_rnaseq_full_${{ matrix.aligner }}_${{ matrix.arch }}"
revision: ${{ github.sha }}
profiles: test_full_aws
profiles: test_full_aws${{ matrix.arch == 'arm64' && ',wave,arm' || '' }}
parameters: |
{
"hook_url": "${{ secrets.MEGATESTS_ALERTS_SLACK_HOOK_URL }}",
"aligner": "${{ matrix.aligner }}",
"outdir": "${{ secrets.TOWER_BUCKET_AWS }}/rnaseq/results-${{ github.sha }}/aligner_${{ matrix.aligner }}/"
"outdir": "${{ secrets.TOWER_BUCKET_AWS }}/rnaseq/results-${{ github.sha }}/${{ matrix.arch }}/aligner_${{ matrix.aligner }}/"
}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: Tower debug log file
path: tower_action_*.log
Expand Down Expand Up @@ -66,7 +67,7 @@ jobs:
"outdir": "${{ secrets.TOWER_BUCKET_AZURE }}/rnaseq/results-${{ github.sha }}/aligner_${{ matrix.aligner }}/",
"igenomes_base": "${{ secrets.TOWER_IGENOMES_BASE_AZURE }}"
}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: Tower debug log file
path: tower_action_*.log
Expand All @@ -93,7 +94,7 @@ jobs:
"aligner": "${{ matrix.aligner }}",
"outdir": "${{ secrets.TOWER_BUCKET_GCP }}/rnaseq/results-${{ github.sha }}/aligner_${{ matrix.aligner }}/"
}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: Tower debug log file
path: tower_action_*.log
18 changes: 11 additions & 7 deletions .github/workflows/cloud_tests_small.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,25 @@ jobs:
run-small-tests-on-aws:
if: ${{ github.event.inputs.platform == 'all' || github.event.inputs.platform == 'aws' }}
runs-on: ubuntu-latest
strategy:
matrix:
aligner: ["star_salmon", "star_rsem"]
arch: ["arm64", "x86_64"]
steps:
- uses: seqeralabs/action-tower-launch@v2
with:
workspace_id: ${{ secrets.TOWER_WORKSPACE_ID }}
access_token: ${{ secrets.TOWER_ACCESS_TOKEN }}
compute_env: ${{ secrets.TOWER_CE_AWS_CPU }}
compute_env: ${{ matrix.arch == 'arm64' && secrets.TOWER_CE_AWS_CPU_ARM64 || secrets.TOWER_CE_AWS_CPU }}
workdir: "${{ secrets.TOWER_BUCKET_AWS }}/work/rnaseq/work-${{ github.sha }}"
run_name: "aws_rnaseq_small"
run_name: "aws_rnaseq_small_${{ matrix.arch }}"
revision: ${{ github.sha }}
profiles: test
profiles: test${{ matrix.arch == 'arm64' && ',wave,arm' || '' }}
parameters: |
{
"outdir": "${{ secrets.TOWER_BUCKET_AWS }}/rnaseq/results-test-${{ github.sha }}/"
"outdir": "${{ secrets.TOWER_BUCKET_AWS }}/rnaseq/results-test-${{ github.sha }}/${{ matrix.arch }}/aligner_${{ matrix.aligner }}/"
}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: Tower debug log file
path: tower_action_*.log
Expand All @@ -53,7 +57,7 @@ jobs:
{
"outdir": "${{ secrets.TOWER_BUCKET_AZURE }}/rnaseq/results-test-${{ github.sha }}/"
}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: Tower debug log file
path: tower_action_*.log
Expand All @@ -75,7 +79,7 @@ jobs:
{
"outdir": "${{ secrets.TOWER_BUCKET_GCP }}/rnaseq/results-test-${{ github.sha }}/"
}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: Tower debug log file
path: tower_action_*.log
51 changes: 51 additions & 0 deletions .github/workflows/containers_config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
name: Container Configs

on:
# FIXME Remove these and only run on release or PRs to main or TEMPLATE updates
push:
branches: [main,dev]
pull_request:
branches: [main,dev]
release:
types: [published]
# TODO workflow_dispatch:

jobs:
build:
runs-on: ubuntu-latest
env:
FORCE_COLOR: 1
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
with:
token: ${{ secrets.nf_core_bot_auth_token }}
ref: ${{ github.head_ref }}
- uses: nf-core/setup-nextflow@v2
with:
version: "25.01.0-edge"
- name: Snapshot containers
run: |
mkdir -p conf/containers
for container in docker singularity; do
for arch in amd64 arm64; do
if [ "$arch" = "arm64" ]; then
profile="wave,$container,arm"
else
profile="wave,$container"
fi
nextflow inspect . -profile $profile -format config > conf/containers/containers_${container}_${arch}.config
echo "Created conf/containers/containers_${container}_${arch}.config"
sort -o conf/containers/containers_${container}_${arch}.config conf/containers/containers_${container}_${arch}.config
done
done
- name: Commit & push changes
id: commit-and-push
run: |
git config user.email "[email protected]"
git config user.name "nf-core-bot"
git config push.default upstream
git add conf/containers/.
git status
git commit -m "[automated] Update container configs"
git push

Loading
Loading