Update README.md - add link_fabric_delete_mode and edge_connections_delete_mode #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juburnet
added
documentation
mtarking
reviewed
May 12, 2025
| @@ -85,6 +85,7 @@ The following control variables are available in this collection. | |||
| | `force_run_all` | Force all roles in the collection to run | `false` | | |||
| | `interface_delete_mode` | Remove interface state as part of the remove role | `false` | | |||
| | `inventory_delete_mode` | Remove inventory state as part of the remove role | `false` | | |||
| | `link_fabric_delete_mode` | Remove fabric link state as part of the remove role | `false` | | |||
There was a problem hiding this comment.
Is this for intra fabric links and edge connections?
There was a problem hiding this comment.
@mtarking this is for intra fabric links only. It was added in PR #194 but not updated in all locations.
It's in use in links.yml in remove role: "Manage NDFC Fabric Links" for common and isn remove tasks.
It looks like @mthurstocisco added a new variable for Edge Connections - "edge_connections_delete_mode" in PR #280 . However, it looks like we don't have that in all the docs either. I will update this PR and change the title to include Edge in the docs
There was a problem hiding this comment.
@juburnet is there usage implemented everywhere we expect across common and/or different fabric types?
juburnet
changed the title
mikewiebe
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Related Collection Role
Related Data Model Element
Proposed Changes
update readme.md
Test Notes
na
Cisco NDFC Version
na
Checklist